Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iterpath and iterdir to CSS test runner. #18959

Merged
merged 1 commit into from Oct 21, 2017
Merged

Add iterpath and iterdir to CSS test runner. #18959

merged 1 commit into from Oct 21, 2017

Conversation

glennw
Copy link
Member

@glennw glennw commented Oct 19, 2017 •
edited by SimonSapin

This allows running a subset of the CSS tests again, by specifying
a directory or single test.

Fixes #18931.

This change is Reviewable

@gw3583
Add iterpath and iterdir to CSS test runner.
d42a00d 
This allows running a subset of the CSS tests again, by specifying
a directory or single test.

Fixes servo#18931.
@highfive
Copy link

warning Warning warning

  • This pull request modifies the contents of
    tests/wpt/css-tests/, which are overwriten occasionally whenever the
    directory is synced from upstream.

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 19, 2017
@glennw
Copy link
Member Author

glennw commented Oct 19, 2017

r? @jdm

@highfive highfive assigned jdm and unassigned mbrubeck Oct 19, 2017
@jdm
Copy link
Member

jdm commented Oct 19, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit d42a00d has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 19, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit d42a00d with merge bdc7919...

bors-servo pushed a commit that referenced this pull request Oct 21, 2017
Auto merge of #18959 - glennw:css-run, r=jdm
bdc7919 
Add iterpath and iterdir to CSS test runner.

This allows running a subset of the CSS tests again, by specifying
a directory or single test.

Fixes #18931.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18959)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing bdc7919 to master...

@bors-servo bors-servo merged commit d42a00d into servo:master Oct 21, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@glennw @highfive @jdm @bors-servo @mbrubeck @gw3583