Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offscreen #19012

Closed
wants to merge 4 commits into from
Closed

Offscreen #19012

wants to merge 4 commits into from

Conversation

jaga4494
Copy link

@jaga4494 jaga4494 commented Oct 25, 2017 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/offscreencanvas.rs, components/script/dom/webidls/OffscreenCanvasRenderingContext2d.webidl, components/script/dom/offscreencanvasrenderingcontext2d.rs, components/script/dom/webidls/OffscreenCanvas.webidl
  • @KiChjang: components/script/dom/offscreencanvas.rs, components/script/dom/webidls/OffscreenCanvasRenderingContext2d.webidl, components/script/dom/offscreencanvasrenderingcontext2d.rs, components/script/dom/webidls/OffscreenCanvas.webidl

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 25, 2017
@jdm jdm added the S-needs-code-changes Changes have not yet been made that were requested by a reviewer. label Oct 25, 2017
@highfive highfive removed the S-needs-code-changes Changes have not yet been made that were requested by a reviewer. label Oct 25, 2017
@jdm jdm mentioned this pull request Oct 27, 2017
Closed
@jdm
Copy link
Member

jdm commented Oct 30, 2017

It's hard to tell with so many different pull requests being opened, but I don't think this pull request contains the most recent code.

@jdm jdm closed this Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-review There is new code that needs to be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaga4494 @highfive @jdm