style: Move font-variant-numeric outside of mako #19277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
highfive
added
the
S-awaiting-review
CYBAI
commented
Nov 18, 2017
| } | ||
|
|
||
| #[cfg(feature = "gecko")] | ||
| impl_gecko_keyword_conversions!(VariantNumeric, u8); |
There was a problem hiding this comment.
@emilio Previously, in the PRs of font-variant-east-asian and font-variant-ligatures, I copied the content of impl_gecko_keyword_conversions macro. However, they will be looked like very duplicate codes.
Thus, if using macro is better, I'd like to send another PR to implement this macro for font-variant-east-asian and font-variant-ligatures.
There was a problem hiding this comment.
Great! Thanks; I'll send a PR for it!
emilio
approved these changes
Nov 18, 2017
| } | ||
|
|
||
| #[cfg(feature = "gecko")] | ||
| impl_gecko_keyword_conversions!(VariantNumeric, u8); |
|
@bors-servo r+ |
|
📌 Commit a38de8b has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Nov 18, 2017
style: Move font-variant-numeric outside of mako This is a sub-PR of #19015 r? @emilio --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #19276 - [x] These changes do not require tests <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19277) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
4 tasks
bors-servo
pushed a commit
that referenced
this pull request
Nov 19, 2017
Use macro to impl From for font variant As I discussed in #19277, I'd like to change the implementation for `From` of font variant to use macro, `impl_gecko_keyword_conversions`. r? @emilio --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes update `From` impl for font variant to use macro `impl_gecko_keyword_conversions`. - [x] These changes do not require tests <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19282) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Nov 19, 2017
Use macro to impl From for font variant As I discussed in #19277, I'd like to change the implementation for `From` of font variant to use macro, `impl_gecko_keyword_conversions`. r? @emilio --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes update `From` impl for font variant to use macro `impl_gecko_keyword_conversions`. - [x] These changes do not require tests <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19282) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Nov 20, 2017
Use macro to impl From for font variant As I discussed in #19277, I'd like to change the implementation for `From` of font variant to use macro, `impl_gecko_keyword_conversions`. r? @emilio --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes update `From` impl for font variant to use macro `impl_gecko_keyword_conversions`. - [x] These changes do not require tests <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19282) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sub-PR of #19015
r? emilio
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is