Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clang-sys to work around a Rust miscompilation. #19372

Merged
merged 1 commit into from Nov 25, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Nov 25, 2017

Works around: rust-lang/rust#46239


This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 25, 2017
@emilio
Copy link
Member Author

emilio commented Nov 25, 2017

@bors-servo r=rillian p=1

@bors-servo
Copy link
Contributor

📌 Commit 2c97ae1 has been approved by rillian

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 25, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 2c97ae1 with merge 0fd4ea4...

bors-servo pushed a commit that referenced this pull request Nov 25, 2017
Bump clang-sys to work around a Rust miscompilation.

Works around: rust-lang/rust#46239

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19372)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt3

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 25, 2017
@jdm
Copy link
Member

jdm commented Nov 25, 2017

@bors-servo
Copy link
Contributor

⌛ Testing commit 2c97ae1 with merge 4965886...

bors-servo pushed a commit that referenced this pull request Nov 25, 2017
Bump clang-sys to work around a Rust miscompilation.

Works around: rust-lang/rust#46239

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19372)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 25, 2017
@bors-servo
Copy link
Contributor

💔 Test failed - mac-dev-unit

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 25, 2017
@emilio
Copy link
Member Author

emilio commented Nov 25, 2017

@bors-servo retry

  • Random Gecko media build failure?

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: rillian
Pushing 4965886 to master...

@bors-servo bors-servo merged commit 2c97ae1 into servo:master Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants