style: Stop duplicating slots. #19664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: 1427001 Reviewed-by: smaug MozReview-Commit-ID: Cq647BcOzbe
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
|
|
@bors-servo r=smaug p=1 |
|
📌 Commit dd1cef1 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Dec 31, 2017
style: Stop duplicating slots. Reland of #19660 since it was backed out for not landing its Gecko changes on time. Bug: 1427001 Reviewed-by: smaug MozReview-Commit-ID: Cq647BcOzbe
|
💔 Test failed - linux-dev |
highfive
added
S-tests-failed
highfive
added
S-awaiting-review
|
@bors-servo r=smaug p=1 |
|
📌 Commit e6623e2 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Dec 31, 2017
style: Stop duplicating slots. Reland of #19660 since it was backed out for not landing its Gecko changes on time. Bug: 1427001 Reviewed-by: smaug MozReview-Commit-ID: Cq647BcOzbe <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19664) <!-- Reviewable:end -->
|
💔 Test failed - mac-dev-unit |
highfive
added
S-tests-failed
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Dec 31, 2017
style: Stop duplicating slots. Reland of #19660 since it was backed out for not landing its Gecko changes on time. Bug: 1427001 Reviewed-by: smaug MozReview-Commit-ID: Cq647BcOzbe <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19664) <!-- Reviewable:end -->
highfive
added
the
S-awaiting-merge
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland of #19660 since it was backed out for not landing its Gecko changes on time.
Bug: 1427001
Reviewed-by: smaug
MozReview-Commit-ID: Cq647BcOzbe
This change is