Avoid entraining various Debug impls in release builds #19756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
highfive
added
the
S-awaiting-review
|
r? @emilio |
emilio
approved these changes
Jan 13, 2018
components/style/dom.rs
Outdated
| @@ -746,17 +746,10 @@ pub trait TElement | |||
| /// element-backed pseudo-element, in which case we return the originating | |||
| /// element. | |||
| fn rule_hash_target(&self) -> Self { | |||
| if let Some(pseudo) = self.implemented_pseudo_element() { | |||
| if let Some(_) = self.implemented_pseudo_element() { | |||
There was a problem hiding this comment.
Nit: is_some(). Though this was here to try figure out a crash with editor code and we never saw it in the wild.
components/style/dom.rs
Outdated
| @@ -746,17 +746,10 @@ pub trait TElement | |||
| /// element-backed pseudo-element, in which case we return the originating | |||
| /// element. | |||
| fn rule_hash_target(&self) -> Self { | |||
| if let Some(pseudo) = self.implemented_pseudo_element() { | |||
| if let Some(_) = self.implemented_pseudo_element() { | |||
| match self.closest_non_native_anonymous_ancestor() { | |||
MozReview-Commit-ID: Lp9i9EI5qdU
bholley
force-pushed
the
avoid_debug_impls_in_release
branch
from
d5c3afa
to
f858ce9
Compare
|
@bors-servo r=emilio |
|
📌 Commit f858ce9 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jan 13, 2018
Avoid entraining various Debug impls in release builds See https://bugzilla.mozilla.org/show_bug.cgi?id=1351737#c29 This patch saves more than 80k of code size. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19756) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1351737#c29
This patch saves more than 80k of code size.
This change is