Fix an error in executorservo.py #20055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highfive
added
the
S-awaiting-review
|
Opened new PR for upstreamable changes. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#28. |
|
r? @jdm |
|
@bors-servo r+ |
|
📌 Commit d4d2fdf has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Feb 15, 2018
Fix an error in executorservo.py ``` TypeError: make_hosts_file() takes exactly 2 arguments (0 given) ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20055) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-css2 |
highfive
added
S-tests-failed
``` TypeError: make_hosts_file() takes exactly 2 arguments (0 given) ```
jdm
force-pushed
the
fix-wpt-executor
branch
from
d4d2fdf
to
6d86500
Compare
highfive
added
S-awaiting-review
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#28. |
|
@bors-servo: r+ |
|
📌 Commit 6d86500 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Feb 15, 2018
Fix an error in executorservo.py ``` TypeError: make_hosts_file() takes exactly 2 arguments (0 given) ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20055) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
|
Error syncing changes upstream. Logs saved in error-snapshot-1518716319692. |
highfive
removed
the
S-awaiting-merge
jdm
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 15, 2018
``` TypeError: make_hosts_file() takes exactly 2 arguments (0 given) ``` Upstreamed from servo/servo#20055 [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is