Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ContentItem use a CustomIdent for counter names #20171

Merged
merged 2 commits into from Mar 2, 2018
Merged

Make ContentItem use a CustomIdent for counter names #20171

merged 2 commits into from Mar 2, 2018

Conversation

nox
Copy link
Contributor

@nox nox commented Mar 2, 2018 •
edited by SimonSapin

See w3c/csswg-drafts#2377.

This change is Reviewable

@highfive
Copy link

highfive commented Mar 2, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/values/computed/counters.rs, components/style/values/specified/counters.rs
  • @canaltinova: components/style/properties/gecko.mako.rs, components/style/values/computed/counters.rs, components/style/values/specified/counters.rs
  • @emilio: components/style/properties/gecko.mako.rs, components/style/values/computed/counters.rs, components/style/values/specified/counters.rs, components/layout/generated_content.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 2, 2018
@servo-wpt-sync servo-wpt-sync mentioned this pull request Mar 2, 2018
Merged
@servo-wpt-sync
Copy link
Collaborator

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#32.

@nox nox mentioned this pull request Mar 2, 2018
Merged
@emilio
Copy link
Member

emilio commented Mar 2, 2018

@bors-servo r+

Thanks for the spec change too! \p/

@bors-servo
Copy link
Contributor

📌 Commit 91ed0b0 has been approved by emilio

@highfive highfive assigned emilio and unassigned metajack Mar 2, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 2, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 91ed0b0 with merge 476a076...

bors-servo pushed a commit that referenced this pull request Mar 2, 2018
Auto merge of #20171 - servo:content-item-counters, r=emilio
476a076 
 Make ContentItem use a CustomIdent for counter names

See w3c/csswg-drafts#2377.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20171)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 476a076 to master...

@bors-servo bors-servo merged commit 91ed0b0 into master Mar 2, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 2, 2018
jdm pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 2, 2018
@nox @jdm
Make ContentItem use a CustomIdent for counter names
544c462 
See w3c/csswg-drafts#2377

Upstreamed from servo/servo#20171 [ci skip]
@servo-wpt-sync servo-wpt-sync mentioned this pull request Mar 2, 2018
Merged
@emilio emilio mentioned this pull request Mar 2, 2018
Merged
@SimonSapin SimonSapin deleted the content-item-counters branch March 5, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nox @highfive @servo-wpt-sync @emilio @bors-servo @metajack