Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support i686-linux-android target for android-x86 emulator #20472

Merged
merged 1 commit into from May 23, 2018
Merged

Support i686-linux-android target for android-x86 emulator #20472

merged 1 commit into from May 23, 2018

Conversation

jdm
Copy link
Member

@jdm jdm commented Mar 29, 2018 •
edited by SimonSapin

The first commit allows ./mach build --target=i686-linux-android to build successfully. The second commit is temporary as I attempt to find the cause of the mysterious crash that takes down the browser.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/command_base.py, python/servo/package_commands.py, python/servo/build_commands.py, python/servo/post_build_commands.py
  • @paulrouget: ports/servo/fake-ld-armv7.sh, ports/servo/Cargo.toml, components/servo/lib.rs, ports/servo/glutin_app/window.rs, ports/servo/main.rs and 3 more

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 29, 2018
@jdm
Copy link
Member Author

jdm commented Mar 29, 2018

Relies on szeged/blurdroid#8.

@mbrubeck
Copy link
Contributor

r=mbrubeck on the first commit, if you want to land it now that the new blurdroid release is published.

@jdm jdm changed the title [WIP] Support i686-linux-android target for android-x86 emulator Support i686-linux-android target for android-x86 emulator Mar 29, 2018
@jdm
Copy link
Member Author

jdm commented Mar 29, 2018

@bors-servo r=mbrubeck

@bors-servo
Copy link
Contributor

📌 Commit 068a3d7 has been approved by mbrubeck

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 29, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 068a3d7 with merge fcbdfbd...

bors-servo pushed a commit that referenced this pull request Mar 29, 2018
Auto merge of #20472 - jdm:android-x86-2, r=mbrubeck
fcbdfbd 
Support i686-linux-android target for android-x86 emulator

The first commit allows `./mach build --target=i686-linux-android` to build successfully. The second commit is temporary as I attempt to find the cause of the mysterious crash that takes down the browser.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20472)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - android

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 29, 2018
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 29, 2018
@jdm
Copy link
Member Author

jdm commented Mar 29, 2018

@bors-servo r=mbrubeck

@bors-servo
Copy link
Contributor

📌 Commit 9f061fe has been approved by mbrubeck

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 29, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 9f061fe with merge 5e74271...

bors-servo pushed a commit that referenced this pull request Mar 29, 2018
Auto merge of #20472 - jdm:android-x86-2, r=mbrubeck
5e74271 
Support i686-linux-android target for android-x86 emulator

The first commit allows `./mach build --target=i686-linux-android` to build successfully. The second commit is temporary as I attempt to find the cause of the mysterious crash that takes down the browser.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20472)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 29, 2018
@jdm
Copy link
Member Author

jdm commented May 23, 2018

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit e68c032 with merge e07f2d0...

bors-servo pushed a commit that referenced this pull request May 23, 2018
Auto merge of #20472 - jdm:android-x86-2, r=<try>
e07f2d0 
Support i686-linux-android target for android-x86 emulator

The first commit allows `./mach build --target=i686-linux-android` to build successfully. The second commit is temporary as I attempt to find the cause of the mysterious crash that takes down the browser.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20472)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css1

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label May 23, 2018
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label May 23, 2018
@jdm
Copy link
Member Author

jdm commented May 23, 2018

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 3d641e8 with merge 9372fba...

bors-servo pushed a commit that referenced this pull request May 23, 2018
Auto merge of #20472 - jdm:android-x86-2, r=<try>
9372fba 
Support i686-linux-android target for android-x86 emulator

The first commit allows `./mach build --target=i686-linux-android` to build successfully. The second commit is temporary as I attempt to find the cause of the mysterious crash that takes down the browser.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20472)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css2

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label May 23, 2018
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label May 23, 2018
@jdm
Copy link
Member Author

jdm commented May 23, 2018

@bors-servo r=mbrubeck

@bors-servo
Copy link
Contributor

📌 Commit d6b8aaf has been approved by mbrubeck

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 23, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit d6b8aaf with merge 521748c...

bors-servo pushed a commit that referenced this pull request May 23, 2018
Auto merge of #20472 - jdm:android-x86-2, r=mbrubeck
521748c 
Support i686-linux-android target for android-x86 emulator

The first commit allows `./mach build --target=i686-linux-android` to build successfully. The second commit is temporary as I attempt to find the cause of the mysterious crash that takes down the browser.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20472)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 23, 2018
@jdm
Copy link
Member Author

jdm commented May 23, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1, mac-rel-wpt4...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: mbrubeck
Pushing 521748c to master...

@bors-servo bors-servo merged commit d6b8aaf into servo:master May 23, 2018
Android MVP automation moved this from In progress to Done May 23, 2018
@jdm jdm mentioned this pull request Jun 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
Android
Status: Done
Android MVP
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdm @highfive @mbrubeck @bors-servo