Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Sync changes from mozilla-central. #20751

Merged
merged 19 commits into from May 5, 2018
Merged

style: Sync changes from mozilla-central. #20751

merged 19 commits into from May 5, 2018

Conversation

emilio
Copy link
Member

@emilio emilio commented May 5, 2018 •
edited by SimonSapin

See each commit for details.

This change is Reviewable

upsuper and others added 13 commits May 5, 2018 16:19
@upsuper @emilio
style: Make KTableEntry an independent type.
8c322b9 
Bug: 1448759
Reviewed-by: heycam
MozReview-Commit-ID: oZfJAigThN
@emilio
style: Derive ToCss for Counters.
a375baf 
Bug: 1457332
Reviewed-by: xidorn
MozReview-Commit-ID: 1jOglcqt1Dd
@emilio
style: Move represents_keyword to the css attributes.
c508d85 
Bug: 1457635
Reviewed-by: xidorn
MozReview-Commit-ID: 21yuU4h34AQ
@emilio
style: Remove values::Verbatim.
40a6169 
No point of having two things that do the same.

Bug: 1457635
Reviewed-by: xidorn
MozReview-Commit-ID: Do1L4bvOeVQ
@emilio
style: Handle Shadow DOM in keyframes lookup.
4f161d9 
Bug: 1018269
Reviewed-by: heycam
MozReview-Commit-ID: AeUmsOHOUYR
@emilio
style: Merge ServoStyleSheet and StyleSheet.
9ed4895 
These are the most minimal changes I could make. More cleanups incoming.

Bug: 1457920
Reviewed-by: xidorn
MozReview-Commit-ID: AdMOA1acQIH
@emilio
style: Remove ServoStyleSheet usage.
9d72107 
Bug: 1457920
Reviewed-by: xidorn
MozReview-Commit-ID: LIBkovuQ6MB
@emilio
style: Fix perspective interpolation.
0ef70d5 
It's not sound to insert random matrices in random positions in the transform
operation list.

I cannot make any sense of what the old code was trying to do.

Bug: 1458715
Reviewed-by: hiro
MozReview-Commit-ID: 5BtCiueEPlR
@emilio
style: Make the font canvas code not mess with the rule tree.
6ecc744 
Inserting a lot of rules in the root level is super-inefficient. This fixes it
by not doing it.

It gives the root rule node to the style, but that's fine, since it's useless.
All this code-path is already pretty messy.

Bug: 1457678
Reviewed-by: xidorn,hiro
MozReview-Commit-ID: GoGHI4YJbKr
@jwatt @emilio
style: Remove the 'property_name' macro.
12913d0 
Bug: 1458219
Reviewed-by: xidorn
@upsuper @emilio
style: Allow 16% false positives in test bloom::create_and_insert_som…
09b22ab 
…e_stuff.

It seems that the result of hash algorithm used in bloom filter depends
on the pointer length. On 64bit platforms, there are 135 false positives
in the first part of that test, and 8 in the second part. However, on
32bit platforms, the numbers become 157 and 16 correspondingly.

16 is still less than 20% in the second part, so all fine, but 157 is
slightly larger than 15% in the test assertion. Given it is what we are
shipping, we probably should just accept this and loosen the assertion.

Bug: 1457524
Reviewed-by: heycam
MozReview-Commit-ID: 9kFXBzLFAzE
@emilio
style: Fix tidy issues.
39169ad
@emilio
style: Fix servo build.
33b593d
@highfive
Copy link

highfive commented May 5, 2018

Heads up! This PR modifies the following files:

  • @bholley: ports/geckolib/glue.rs, components/selectors/bloom.rs, components/style/properties/gecko.mako.rs, components/style/values/generics/counters.rs, components/style/properties/properties.mako.rs and 16 more
  • @canaltinova: components/style/properties/gecko.mako.rs, components/style/values/generics/counters.rs, components/style/properties/properties.mako.rs, components/style/gecko/media_queries.rs, components/style/matching.rs and 12 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 5, 2018
@highfive
Copy link

highfive commented May 5, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!

@emilio
Copy link
Member Author

emilio commented May 5, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 33b593d has been approved by emilio

@highfive highfive assigned emilio and unassigned pcwalton May 5, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 5, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 33b593d with merge d629d48...

bors-servo pushed a commit that referenced this pull request May 5, 2018
Auto merge of #20751 - emilio:gecko-sync, r=emilio
d629d48 
style: Sync changes from mozilla-central.

See each commit for details.
@bors-servo
Copy link
Contributor

💔 Test failed - mac-dev-unit

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 5, 2018
@emilio
style: Implement Debug for KeyframeAnimationStyle by hand.
cb48a83 
The ComputedValues format is huge and unneeded.
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label May 5, 2018
@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 5, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 3f6ce9d with merge 2ca7a53...

bors-servo pushed a commit that referenced this pull request May 5, 2018
Auto merge of #20751 - emilio:gecko-sync, r=emilio
2ca7a53 
style: Sync changes from mozilla-central.

See each commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20751)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 5, 2018
@emilio
Copy link
Member Author

emilio commented May 5, 2018

@bors-servo r+

  • Added some other changes that were on inbound already.

@bors-servo
Copy link
Contributor

📌 Commit 51da54e has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 5, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 51da54e with merge a0d7e94...

bors-servo pushed a commit that referenced this pull request May 5, 2018
Auto merge of #20751 - emilio:gecko-sync, r=emilio
a0d7e94 
style: Sync changes from mozilla-central.

See each commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20751)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 5, 2018
emilio added 4 commits May 5, 2018 18:53
@emilio
style: Remove a useless unit test that no longer compiles.
953ba58
@emilio
style: Make SMIL values not roundtrip through strings.
83cb099 
Bug: 1458814
Reviewed-by: hiro
MozReview-Commit-ID: DpbFSutIv3t
@emilio
style: Remove a bit of trivially dead code.
5668812 
Bug: 1458814
Reviewed-by: hiro
MozReview-Commit-ID: GG41v4TejBU
@emilio
style: Remove code that is no longer called.
16815bf 
Au revoir!

Bug: 1458814
Reviewed-by: hiro
MozReview-Commit-ID: DjqszUSIzXs
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels May 5, 2018
@emilio
Copy link
Member Author

emilio commented May 5, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 16815bf has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 5, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 16815bf with merge 719e4e3...

bors-servo pushed a commit that referenced this pull request May 5, 2018
Auto merge of #20751 - emilio:gecko-sync, r=emilio
719e4e3 
style: Sync changes from mozilla-central.

See each commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20751)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 719e4e3 to master...

@bors-servo bors-servo merged commit 16815bf into servo:master May 5, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@emilio @highfive @bors-servo @pcwalton @upsuper @jwatt