Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Sync changes from mozilla-central. #20751

Merged
merged 19 commits into from May 5, 2018
Merged

style: Sync changes from mozilla-central. #20751

merged 19 commits into from May 5, 2018

Commits on May 5, 2018

  1. style: Make KTableEntry an independent type. 

    Bug: 1448759
Reviewed-by: heycam
MozReview-Commit-ID: oZfJAigThN
    @upsuper @emilio
    upsuper authored and emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    8c322b9 View commit details
    Browse the repository at this point in the history

  2. style: Derive ToCss for Counters. 

    Bug: 1457332
Reviewed-by: xidorn
MozReview-Commit-ID: 1jOglcqt1Dd
    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    a375baf View commit details
    Browse the repository at this point in the history

  3. style: Move represents_keyword to the css attributes. 

    Bug: 1457635
Reviewed-by: xidorn
MozReview-Commit-ID: 21yuU4h34AQ
    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    c508d85 View commit details
    Browse the repository at this point in the history

  4. style: Remove values::Verbatim. 

    No point of having two things that do the same.

Bug: 1457635
Reviewed-by: xidorn
MozReview-Commit-ID: Do1L4bvOeVQ
    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    40a6169 View commit details
    Browse the repository at this point in the history

  5. style: Handle Shadow DOM in keyframes lookup. 

    Bug: 1018269
Reviewed-by: heycam
MozReview-Commit-ID: AeUmsOHOUYR
    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    4f161d9 View commit details
    Browse the repository at this point in the history

  6. style: Merge ServoStyleSheet and StyleSheet. 

    These are the most minimal changes I could make. More cleanups incoming.

Bug: 1457920
Reviewed-by: xidorn
MozReview-Commit-ID: AdMOA1acQIH
    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    9ed4895 View commit details
    Browse the repository at this point in the history

  7. style: Remove ServoStyleSheet usage. 

    Bug: 1457920
Reviewed-by: xidorn
MozReview-Commit-ID: LIBkovuQ6MB
    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    9d72107 View commit details
    Browse the repository at this point in the history

  8. style: Fix perspective interpolation. 

    It's not sound to insert random matrices in random positions in the transform
operation list.

I cannot make any sense of what the old code was trying to do.

Bug: 1458715
Reviewed-by: hiro
MozReview-Commit-ID: 5BtCiueEPlR
    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    0ef70d5 View commit details
    Browse the repository at this point in the history

  9. style: Make the font canvas code not mess with the rule tree. 

    Inserting a lot of rules in the root level is super-inefficient. This fixes it
by not doing it.

It gives the root rule node to the style, but that's fine, since it's useless.
All this code-path is already pretty messy.

Bug: 1457678
Reviewed-by: xidorn,hiro
MozReview-Commit-ID: GoGHI4YJbKr
    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    6ecc744 View commit details
    Browse the repository at this point in the history

  10. style: Remove the 'property_name' macro. 

    Bug: 1458219
Reviewed-by: xidorn
    @jwatt @emilio
    jwatt authored and emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    12913d0 View commit details
    Browse the repository at this point in the history

  11. style: Allow 16% false positives in test bloom::create_and_insert_som… 

    …e_stuff.

It seems that the result of hash algorithm used in bloom filter depends
on the pointer length. On 64bit platforms, there are 135 false positives
in the first part of that test, and 8 in the second part. However, on
32bit platforms, the numbers become 157 and 16 correspondingly.

16 is still less than 20% in the second part, so all fine, but 157 is
slightly larger than 15% in the test assertion. Given it is what we are
shipping, we probably should just accept this and loosen the assertion.

Bug: 1457524
Reviewed-by: heycam
MozReview-Commit-ID: 9kFXBzLFAzE
    @upsuper @emilio
    upsuper authored and emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    09b22ab View commit details
    Browse the repository at this point in the history

  12. style: Fix tidy issues.

    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    39169ad View commit details
    Browse the repository at this point in the history

  13. style: Fix servo build.

    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    33b593d View commit details
    Browse the repository at this point in the history

  14. style: Implement Debug for KeyframeAnimationStyle by hand. 

    The ComputedValues format is huge and unneeded.
    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    cb48a83 View commit details
    Browse the repository at this point in the history

  15. style: Remove some unneeded cfg(..). 

    The less not-compiled code in common builds, the better for everybody.
    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    921c389 View commit details
    Browse the repository at this point in the history

  16. style: Remove a useless unit test that no longer compiles.

    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    953ba58 View commit details
    Browse the repository at this point in the history

  17. style: Make SMIL values not roundtrip through strings. 

    Bug: 1458814
Reviewed-by: hiro
MozReview-Commit-ID: DpbFSutIv3t
    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    83cb099 View commit details
    Browse the repository at this point in the history

  18. style: Remove a bit of trivially dead code. 

    Bug: 1458814
Reviewed-by: hiro
MozReview-Commit-ID: GG41v4TejBU
    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    5668812 View commit details
    Browse the repository at this point in the history

  19. style: Remove code that is no longer called. 

    Au revoir!

Bug: 1458814
Reviewed-by: hiro
MozReview-Commit-ID: DjqszUSIzXs
    @emilio
    emilio committed May 5, 2018
    Configuration menu
    Copy the full SHA
    16815bf View commit details
    Browse the repository at this point in the history