New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downloading huge files (broken since hyperup) #22144

Merged
merged 3 commits into from Nov 8, 2018

Conversation

Projects
None yet
6 participants
@Eijebong
Member

Eijebong commented Nov 8, 2018

This change is Reviewable

Eijebong added some commits Nov 8, 2018

Don't reset the buffers for each chunk we download
Sometimes hyper sends data that can't completely decompressed, resetting
the buffer means we're losing some data and thus breaking the body
Continue decompressing chunks even after hyper is done downloading th…
…e body

If hyper reads compressed enough data, we were decompressing 32k by 32k
but we were throwing away the end of the body because we would end up
having lots of backed up data in the cursor when hyper was done.
@highfive

This comment has been minimized.

highfive commented Nov 8, 2018

Heads up! This PR modifies the following files:

@highfive

This comment has been minimized.

highfive commented Nov 8, 2018

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@Eijebong

This comment has been minimized.

Member

Eijebong commented Nov 8, 2018

@jdm

This comment has been minimized.

Member

jdm commented Nov 8, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 8, 2018

📌 Commit dcbe7d3 has been approved by jdm

@highfive highfive assigned jdm and unassigned Manishearth Nov 8, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 8, 2018

⌛️ Testing commit dcbe7d3 with merge 8ebac59...

bors-servo added a commit that referenced this pull request Nov 8, 2018

Auto merge of #22144 - Eijebong:hyperfix, r=jdm
Fix downloading huge files (broken since hyperup)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22144)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 8, 2018

💔 Test failed - linux-rel-wpt

@Eijebong

This comment has been minimized.

Member

Eijebong commented Nov 8, 2018

[Errno 12] Cannot allocate memory

Show resolved Hide resolved components/net/connector.rs Outdated
@jdm

This comment has been minimized.

Member

jdm commented Nov 8, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 8, 2018

📌 Commit 85c6eff has been approved by jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 8, 2018

⌛️ Testing commit 85c6eff with merge 5e3b67f...

bors-servo added a commit that referenced this pull request Nov 8, 2018

Auto merge of #22144 - Eijebong:hyperfix, r=jdm
Fix downloading huge files (broken since hyperup)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22144)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 8, 2018

💔 Test failed - status-taskcluster

@jdm

This comment has been minimized.

Member

jdm commented Nov 8, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 8, 2018

⌛️ Testing commit 85c6eff with merge dd5e5e9...

bors-servo added a commit that referenced this pull request Nov 8, 2018

Auto merge of #22144 - Eijebong:hyperfix, r=jdm
Fix downloading huge files (broken since hyperup)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22144)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 8, 2018

💔 Test failed - mac-rel-wpt1

@jdm

This comment has been minimized.

Member

jdm commented Nov 8, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 8, 2018

@bors-servo

This comment has been minimized.

@bors-servo bors-servo merged commit 85c6eff into servo:master Nov 8, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment