Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to use test-css command in CI. #22176

Merged
merged 2 commits into from Nov 17, 2018
Merged

Don't try to use test-css command in CI. #22176

merged 2 commits into from Nov 17, 2018

Conversation

jdm
Copy link
Member

@jdm jdm commented Nov 12, 2018

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 12, 2018
done
while read test_name; do
echo " - Checking ${test_name}"
./mach "test-${test_type}" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is test_type defined after these changes?

@jdm
Copy link
Member Author

jdm commented Nov 13, 2018

Good catch!

@KiChjang
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 86c5056 has been approved by KiChjang

@highfive highfive assigned KiChjang and unassigned asajeffrey Nov 13, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 13, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 86c5056 with merge f725ab7...

bors-servo pushed a commit that referenced this pull request Nov 13, 2018
Don't try to use test-css command in CI.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22176)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 13, 2018
@jdm
Copy link
Member Author

jdm commented Nov 15, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 86c5056 with merge 7ac2d77...

bors-servo pushed a commit that referenced this pull request Nov 16, 2018
Don't try to use test-css command in CI.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22176)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 16, 2018
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 16, 2018
@jdm
Copy link
Member Author

jdm commented Nov 16, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 86c5056 with merge b453058...

bors-servo pushed a commit that referenced this pull request Nov 16, 2018
Don't try to use test-css command in CI.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22176)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 16, 2018
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 16, 2018
@jdm
Copy link
Member Author

jdm commented Nov 16, 2018

@bors-servo retry

bors-servo pushed a commit that referenced this pull request Nov 16, 2018
Don't try to use test-css command in CI.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22176)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 86c5056 with merge ebe508d...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 16, 2018
@bors-servo
Copy link
Contributor

💔 Test failed - android-x86

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 16, 2018
@jdm
Copy link
Member Author

jdm commented Nov 17, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 86c5056 with merge f142163...

bors-servo pushed a commit that referenced this pull request Nov 17, 2018
Don't try to use test-css command in CI.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22176)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 17, 2018
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 17, 2018
@jdm
Copy link
Member Author

jdm commented Nov 17, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 86c5056 with merge 679fb36...

bors-servo pushed a commit that referenced this pull request Nov 17, 2018
Don't try to use test-css command in CI.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22176)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 17, 2018
@bors-servo
Copy link
Contributor

@bors-servo bors-servo merged commit 86c5056 into master Nov 17, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 17, 2018
@SimonSapin SimonSapin deleted the jdm-patch-20 branch November 19, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants