Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preload servo.org #22263

Merged
merged 3 commits into from Nov 28, 2018
Merged

Preload servo.org #22263

merged 3 commits into from Nov 28, 2018

Conversation

Darkspirit
Copy link
Sponsor Contributor

@Darkspirit Darkspirit commented Nov 23, 2018 •
edited by SimonSapin

Pending submissions of servo.org and searchfox.org were merged into the HSTS Preload list today.
r? @jdm

  • ./mach test-tidy does not report any errors

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/PerformanceResourceTiming.webidl, components/script/dom/webidls/PerformanceNavigationTiming.webidl, components/script/dom/performanceresourcetiming.rs, components/script/dom/performancenavigationtiming.rs
  • @wafflespeanut: python/servo/servo-binary-formula.rb.in
  • @KiChjang: components/script/dom/webidls/PerformanceResourceTiming.webidl, components/script/dom/webidls/PerformanceNavigationTiming.webidl, components/script/dom/performanceresourcetiming.rs, components/script/dom/performancenavigationtiming.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 23, 2018
@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@servo-wpt-sync servo-wpt-sync mentioned this pull request Nov 25, 2018
Closed
@servo-wpt-sync
Copy link
Collaborator

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14225.

@nox
Copy link
Contributor

nox commented Nov 27, 2018

Please squash the two last commits together.

@servo-wpt-sync
Copy link
Collaborator

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14225.

1 similar comment
@servo-wpt-sync
Copy link
Collaborator

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14225.

@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 27, 2018
@servo-wpt-sync
Copy link
Collaborator

No upstreamable changes; closed existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14225.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Nov 27, 2018
@jdm
Copy link
Member

jdm commented Nov 27, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 8bd79eb has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 27, 2018
@Manishearth Manishearth reopened this Nov 28, 2018
@Manishearth
Copy link
Member

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

📌 Commit f1f409f has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit f1f409f with merge 3f0643c...

bors-servo pushed a commit that referenced this pull request Nov 28, 2018
Auto merge of #22263 - Darkspirit:servo_preload, r=jdm
3f0643c 
Preload servo.org

Pending submissions of servo.org and searchfox.org were [merged](https://chromium.googlesource.com/chromium/src/net/+log/master/http/transport_security_state_static.json) into the HSTS Preload list today.
r? @jdm

---
- [x] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22263)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev
Approved by: jdm
Pushing 3f0643c to master...

@bors-servo bors-servo merged commit f1f409f into servo:master Nov 28, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 28, 2018
@Darkspirit Darkspirit deleted the servo_preload branch November 28, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm requested changes

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Darkspirit @highfive @servo-wpt-sync @nox @jdm @bors-servo @Manishearth