Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CustomEvent (#2173) #2374

Merged
merged 1 commit into from May 23, 2014
Merged

Conversation

Manishearth
Copy link
Member

This was previously PR'd on #2218

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/1510

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member

jdm commented May 23, 2014

Needs a rebase, and then it's mergeable.

bors-servo pushed a commit that referenced this pull request May 23, 2014
@jdm
Copy link
Member

jdm commented May 23, 2014

13:57:43     INFO -  /builds/slave/mac/build/src/components/script/dom/customevent.rs:45:73: 45:74 error: obsolete syntax: `~` notation for owned pointer allocation
13:57:43     INFO -  /builds/slave/mac/build/src/components/script/dom/customevent.rs:45         reflect_dom_object(~CustomEvent::new_inherited(CustomEventTypeId),
13:57:43     INFO -                                                                                                                                              ^
13:57:43     INFO -  note: use the `box` operator instead of `~`
13:57:43     INFO -  error: aborting due to previous error

bors-servo pushed a commit that referenced this pull request May 23, 2014
@bors-servo bors-servo merged commit 4c997e8 into servo:master May 23, 2014
@Manishearth Manishearth deleted the customevent branch June 12, 2014 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants