Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support [LegacyWindowAlias] #24475

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Support [LegacyWindowAlias] #24475

merged 1 commit into from
Oct 19, 2019

Conversation

saschanaz
Copy link
Contributor

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix Support [LegacyWindowAlias] #24474 (GitHub issue number if applicable)
  • There are tests for these changes

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/webidls/URL.webidl, components/script/dom/bindings/interface.rs
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/webidls/URL.webidl, components/script/dom/bindings/interface.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 17, 2019
@saschanaz
Copy link
Contributor Author

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

⌛ Trying commit 27c47b4 with merge fde26f4...

bors-servo pushed a commit that referenced this pull request Oct 17, 2019
Auto merge of #24475 - saschanaz:legacywindowalias, r=<try>
fde26f4 
Support [LegacyWindowAlias]

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24474 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Oct 17, 2019
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Oct 17, 2019
@saschanaz
Copy link
Contributor Author

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

⌛ Trying commit f470892 with merge 500c4ac...

bors-servo pushed a commit that referenced this pull request Oct 17, 2019
Auto merge of #24475 - saschanaz:legacywindowalias, r=<try>
500c4ac 
Support [LegacyWindowAlias]

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24474 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

nox
nox reviewed Oct 17, 2019
View reviewed changes
Copy link
Contributor

@nox nox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, r=me otherwise. Thanks for your contribution!

@nox
Copy link
Contributor

nox commented Oct 17, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit f470892 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 17, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit f470892 with merge 873b1a6...

bors-servo pushed a commit that referenced this pull request Oct 17, 2019
Auto merge of #24475 - saschanaz:legacywindowalias, r=nox
873b1a6 
Support [LegacyWindowAlias]

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24474 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 17, 2019
@saschanaz
Copy link
Contributor Author

saschanaz commented Oct 17, 2019 •
edited

Sorry to push again. Fixed a test-tidy error, interface map data generation (this caused a bug in WebKitCSSMatrix test), and also added WebKitCSSMatrix.

@nox
Copy link
Contributor

nox commented Oct 17, 2019

No worries.

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit e78c3a6 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 17, 2019
@saschanaz saschanaz mentioned this pull request Oct 18, 2019
Closed
@jdm
Copy link
Member

jdm commented Oct 18, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit fc96f30 has been approved by jdm

@highfive highfive assigned jdm and unassigned nox Oct 18, 2019
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 18, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit fc96f30 with merge 5b4d96d...

bors-servo pushed a commit that referenced this pull request Oct 18, 2019
Auto merge of #24475 - saschanaz:legacywindowalias, r=jdm
5b4d96d 
Support [LegacyWindowAlias]

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24474 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 18, 2019
@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #24476) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Oct 18, 2019
jdm
jdm reviewed Oct 19, 2019
View reviewed changes
tests/wpt/mozilla/tests/mozilla/interfaces.js Outdated
"WeakMap",
"WeakSet",
"WebKitCSSMatrix",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops; this belongs in interfaces.html instead, and with a lowercase K.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoooops!! Fixed it. It's WebKitCSSMatrix anyway though, as WebKit people somehow decided to use uppercase K here.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 19, 2019
@jdm
Copy link
Member

jdm commented Oct 19, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit e81b678 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Oct 19, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit e81b678 with merge 605ddbe...

bors-servo pushed a commit that referenced this pull request Oct 19, 2019
Auto merge of #24475 - saschanaz:legacywindowalias, r=jdm
605ddbe 
Support [LegacyWindowAlias]

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24474 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 605ddbe to master...

@bors-servo bors-servo merged commit e81b678 into servo:master Oct 19, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 19, 2019
@saschanaz saschanaz deleted the legacywindowalias branch October 19, 2019 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm left review comments

@nox nox nox left review comments

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support [LegacyWindowAlias]
5 participants
@saschanaz @highfive @bors-servo @nox @jdm