Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GPUComputePassEncoder functions #25793

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Implement GPUComputePassEncoder functions #25793

merged 1 commit into from
Feb 19, 2020

Conversation

imiklos
Copy link

@imiklos imiklos commented Feb 18, 2020

Implement the dispatch, endPass, setBindGroup, setPipeline functions of GPUComputePassEncoder.

cc @kvark @jdm @zakorgy

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/GPUComputePassEncoder.webidl, components/script/dom/gpucomputepassencoder.rs, components/script/dom/webidls/GPUProgrammablePassEncoder.webidl, components/script/dom/bindings/trace.rs, components/script/dom/gpubindgroup.rs and 2 more
  • @KiChjang: components/script/dom/webidls/GPUComputePassEncoder.webidl, components/script/dom/gpucomputepassencoder.rs, components/script/dom/webidls/GPUProgrammablePassEncoder.webidl, components/script/dom/bindings/trace.rs, components/script/dom/gpubindgroup.rs and 2 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 18, 2020
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!

@imiklos imiklos force-pushed the wgpu_compute_pass_encoder_fns branch from a17322d to 817cfd4 Compare February 18, 2020 16:00
@imiklos
Copy link
Author

imiklos commented Feb 18, 2020

I've removed the mach and nix crates from the ignore duplicates list.

kvark
kvark approved these changes Feb 18, 2020
View reviewed changes
Cargo.lock Outdated
@@ -6758,10 +6709,9 @@ dependencies = [
[[package]]
name = "wgpu-core"
version = "0.1.0"
source = "git+https://github.com/gfx-rs/wgpu#d4a46cb60e71d6b108e9052cc581e52e44a16a44"
source = "git+https://github.com/imiklos/wgpu?branch=command_encoder_public#079da18c533011722ad836c01b58511d3ee870df"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you using a custom branch here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only temporary, just for the review. I will update this. This patch is depends on this pull request: gfx-rs/wgpu#496

@jdm jdm assigned jdm and unassigned SimonSapin Feb 18, 2020
@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 18, 2020
@imiklos imiklos force-pushed the wgpu_compute_pass_encoder_fns branch from 817cfd4 to 6d244e1 Compare February 19, 2020 10:02
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Feb 19, 2020
@imiklos
Copy link
Author

imiklos commented Feb 19, 2020

I've changed back the wgpu-core from the forked one and used the already exposed ffi functions for encode passes as @kvark mentioned.

Implement GPUComputePassEncoder functions
170e997 
Implement the `dispatch`, `endPass`, `setBindGroup`, `setPipeline` functions of `GPUComputePassEncoder`.
@imiklos imiklos force-pushed the wgpu_compute_pass_encoder_fns branch from 6d244e1 to 170e997 Compare February 19, 2020 10:26
@jdm
Copy link
Member

jdm commented Feb 19, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 170e997 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 19, 2020
@bors-servo
Copy link
Contributor

⌛ Testing commit 170e997 with merge 7863ac7...

bors-servo pushed a commit that referenced this pull request Feb 19, 2020
Auto merge of #25793 - szeged:wgpu_compute_pass_encoder_fns, r=jdm
7863ac7 
Implement GPUComputePassEncoder functions

Implement the `dispatch`, `endPass`, `setBindGroup`, `setPipeline` functions of `GPUComputePassEncoder`.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes addresses a part of #24706

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
cc @kvark @jdm @zakorgy
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 19, 2020
@jdm
Copy link
Member

jdm commented Feb 19, 2020

@bors-servo retry

bors-servo pushed a commit that referenced this pull request Feb 19, 2020
Auto merge of #25793 - szeged:wgpu_compute_pass_encoder_fns, r=jdm
14851ce 
Implement GPUComputePassEncoder functions

Implement the `dispatch`, `endPass`, `setBindGroup`, `setPipeline` functions of `GPUComputePassEncoder`.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes addresses a part of #24706

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
cc @kvark @jdm @zakorgy
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 170e997 with merge 14851ce...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Feb 19, 2020
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 19, 2020
@jdm
Copy link
Member

jdm commented Feb 19, 2020

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 170e997 with merge 8913c67...

bors-servo pushed a commit that referenced this pull request Feb 19, 2020
Auto merge of #25793 - szeged:wgpu_compute_pass_encoder_fns, r=jdm
8913c67 
Implement GPUComputePassEncoder functions

Implement the `dispatch`, `endPass`, `setBindGroup`, `setPipeline` functions of `GPUComputePassEncoder`.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes addresses a part of #24706

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
cc @kvark @jdm @zakorgy
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Feb 19, 2020
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 19, 2020
@jdm
Copy link
Member

jdm commented Feb 19, 2020

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 170e997 with merge 107a291...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Feb 19, 2020
@bors-servo
Copy link
Contributor

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 107a291 to master...

@bors-servo bors-servo merged commit 107a291 into servo:master Feb 19, 2020
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

@kvark kvark kvark approved these changes

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@imiklos @highfive @jdm @bors-servo @kvark @SimonSapin