Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReport error when vcvarsall fails #26198
Merged
Conversation
highfive
commented
Apr 16, 2020
|
Heads up! This PR modifies the following files:
|
python/servo/build_commands.py
Outdated
| @@ -315,11 +315,15 @@ def build(self, release=False, dev=False, jobs=None, params=None, media_stack=No | |||
| process = subprocess.Popen('("%s" %s > nul) && "python" -c "import os; print(repr(os.environ))"' % | |||
| (os.path.join(vs_dirs['vcdir'], "Auxiliary", "Build", "vcvarsall.bat"), "x64"), | |||
| stdout=subprocess.PIPE, shell=True) | |||
| stdout, _ = process.communicate() | |||
| stdout, err = process.communicate() | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 16, 2020
Report error when vcvarsall fails In trying to get my Windows cross build working on my desktop, I ended up spending a lot of time trying to replicate a failure within servo's build system that ultimately turned out to be vcvarsall silently failing (I was missing a trailing slash in my `VSINSTALLDIR` env var, which vcvarsall does not handle well at all) We should report an error when this happens. r? @jdm
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Apr 16, 2020
Report error when vcvarsall fails In trying to get my Windows cross build working on my desktop, I ended up spending a lot of time trying to replicate a failure within servo's build system that ultimately turned out to be vcvarsall silently failing (I was missing a trailing slash in my `VSINSTALLDIR` env var, which vcvarsall does not handle well at all) We should report an error when this happens. r? @jdm
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedApr 16, 2020
•
edited
In trying to get my Windows cross build working on my desktop, I ended up spending a lot of time trying to replicate a failure within servo's build system that ultimately turned out to be vcvarsall silently failing (I was missing a trailing slash in my
VSINSTALLDIRenv var, which vcvarsall does not handle well at all)We should report an error when this happens.
r? @jdm