Report error when vcvarsall fails #26198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
jdm
requested changes
Apr 16, 2020
python/servo/build_commands.py
Outdated
| @@ -315,11 +315,15 @@ def build(self, release=False, dev=False, jobs=None, params=None, media_stack=No | |||
| process = subprocess.Popen('("%s" %s > nul) && "python" -c "import os; print(repr(os.environ))"' % | |||
| (os.path.join(vs_dirs['vcdir'], "Auxiliary", "Build", "vcvarsall.bat"), "x64"), | |||
| stdout=subprocess.PIPE, shell=True) | |||
| stdout, _ = process.communicate() | |||
| stdout, err = process.communicate() | |||
There was a problem hiding this comment.
Oops, i'd manually copied over the patch
jdm
added
S-needs-code-changes
Manishearth
force-pushed
the
vcvarsall-fail
branch
from
679c28d
to
371ba67
Compare
highfive
added
S-awaiting-review
|
@bors-servo r+ |
|
📌 Commit 371ba67 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
added a commit
that referenced
this pull request
Apr 16, 2020
Report error when vcvarsall fails In trying to get my Windows cross build working on my desktop, I ended up spending a lot of time trying to replicate a failure within servo's build system that ultimately turned out to be vcvarsall silently failing (I was missing a trailing slash in my `VSINSTALLDIR` env var, which vcvarsall does not handle well at all) We should report an error when this happens. r? @jdm
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
bors-servo
added a commit
that referenced
this pull request
Apr 16, 2020
Report error when vcvarsall fails In trying to get my Windows cross build working on my desktop, I ended up spending a lot of time trying to replicate a failure within servo's build system that ultimately turned out to be vcvarsall silently failing (I was missing a trailing slash in my `VSINSTALLDIR` env var, which vcvarsall does not handle well at all) We should report an error when this happens. r? @jdm
highfive
added
S-awaiting-merge
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
|
@bors-servo retry |
highfive
added
the
S-awaiting-merge
|
☀️ Test successful - status-taskcluster |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to get my Windows cross build working on my desktop, I ended up spending a lot of time trying to replicate a failure within servo's build system that ultimately turned out to be vcvarsall silently failing (I was missing a trailing slash in my
VSINSTALLDIRenv var, which vcvarsall does not handle well at all)We should report an error when this happens.
r? @jdm