Added macro to create functions in PipelineNamespace

[AbhishekSharma102]

Changes to constellation_msg.rs to generate namespace id using macros

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix Write a macro to generate namespaced Ids #26380
• These changes do not require tests because no functionality is changed.

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

[jdm]

r? @gterzian

[gterzian]

Thank you, looks likes a great start!

Would it be possible to additional functionality to the macro, maybe via a separate one, that would generate the various Id types, something like namespaced_id!(PipelineId)(which would then also generate the matching PipelineIndex)?

Perhaps this could be done with the same macro, but I am not sure, in that case it could be for example create_pipeline_namespace! {PipelineId, self} that would do what the current macro does, plus would also generate the PipelineId and PipelineIndex types.

[AbhishekSharma102]

Hey!

I believe rust does not allow modification to variable names (like suffix and prefix). I was wondering if we could pass Pipeline to the macro, and it would append Id to get PipelineId and Index to get PipelineIndex . But rust does not allow it. So we would need to pass all the variable names.

We can definitely generate the Id and Index inside the macros. I am thinking of having two macros, one defined in the PR, and another one namespace_id which takes two args, first is id_name like PipelineId and second index_name like PipelineIndex and returns them.

Also I believe two macros would need to be called separately. Please correct if I'm wrong.

Let me know if this sounds good.

[gterzian]

So we would need to pass all the variable names.

Ok, so you mean we'd have to pass PipelineId and PipelineIndex, sounds good to me, definitely better than the current situation.

I am thinking of having two macros, one defined in the PR, and another one namespace_id which takes two args, first is id_name like PipelineId and second index_name like PipelineIndex and returns them.

Sounds good.

Also I believe two macros would need to be called separately. Please correct if I'm wrong.

I'm not sure, let me know what you find out!

[AbhishekSharma102]

Hey, I have added the macro. Let me know if this looks good.

[gterzian]

Looks great! Just one question.

[gterzian]

nit: how about we name it a bit shorter, like namespace_id_method?

[AbhishekSharma102]

renamed it

[AbhishekSharma102]

Hey, updated the name. Let me know if anything else is needed.

[gterzian]

Great! If you can please squash the third commit into the first, then it should be good to go!

[AbhishekSharma102]

Squashed them into one.

[gterzian]

Awesome, thanks!

@bors-servo r+

[bors-servo]

📌 Commit 16c3b89 has been approved by gterzian

[bors-servo]

⌛ Testing commit 16c3b89 with merge 49d0055...

[bors-servo]

☀️ Test successful - status-taskcluster
Approved by: gterzian
Pushing 49d0055 to master...

[AbhishekSharma102]

@gterzian Can you please suggest another issue that I can take up?

[gterzian]

I'm not sure, there are not many issues marked "less easy" any more, perhaps this one: #24684?

If you want something harder I think this one is interesting: #26571 (it might require some more guidance)

[AbhishekSharma102]

I'd like to work on #26571 as I'm hoping there will be more learning. Could you please assign that to me? And please tell on what to read up for the same?