Implement GPURenderPassEncoder #26769

kunalmohan · 2020-06-03T13:57:40Z

Add webidls for GPURenderPassEncoder and GPURenderEncoderBase and
implement relevant methods.

r?@kvark

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #___ (GitHub issue number if applicable)

There are tests for these changes OR
These changes do not require tests because ___

highfive · 2020-06-03T13:57:46Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webidls/GPURenderEncoderBase.webidl, components/script/dom/gpurenderpipeline.rs, components/script/dom/webidls/GPURenderPassEncoder.webidl, components/script/dom/gpucomputepassencoder.rs, components/script/dom/gpudevice.rs and 5 more
@KiChjang: components/script/dom/webidls/GPURenderEncoderBase.webidl, components/script/dom/gpurenderpipeline.rs, components/script/dom/webidls/GPURenderPassEncoder.webidl, components/script/dom/gpucomputepassencoder.rs, components/script/dom/gpudevice.rs and 5 more

highfive · 2020-06-03T13:57:48Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify script code, but no tests are modified. Please consider adding a test!

kunalmohan · 2020-06-03T14:46:53Z

error[E0432]: unresolved import `crate::dom::bindings::codegen::UnionTypes::GPULoadOpOrRangeEnforcedUnsignedLong`
  --> components/script/dom/gpucommandencoder.rs:13:5
   |
13 |     GPULoadOpOrRangeEnforcedUnsignedLong as GPULongLoad,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `GPULoadOpOrRangeEnforcedUnsignedLong` in `dom::bindings::codegen::UnionTypes`

This did not show up during my local build :(

The thing is I have this dictionary in GPUCommandEncoder.webidl

dictionary GPURenderPassDepthStencilAttachmentDescriptor {
    required GPUTextureView attachment;

    required (GPULoadOp or float) depthLoadValue;
    required GPUStoreOp depthStoreOp;
    boolean depthReadOnly = false;

    required (GPULoadOp or GPUStencilValue) stencilLoadValue;
    required GPUStoreOp stencilStoreOp;
    boolean stencilReadOnly = false;
};

I need to match on stencilLoadValue and depthLoadValue for which I need to import their types. Is there someplace else I should import them?

jdm · 2020-06-03T15:28:39Z

This is really strange.
@bors-servo try=linux

bors-servo · 2020-06-03T15:28:44Z

⌛ Trying commit 4b6316c with merge 387495a...

@kvark

Implement GPURenderPassEncoder Add webidls for GPURenderPassEncoder and GPURenderEncoderBase and implement relevant methods.  r?@kvark ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___

bors-servo · 2020-06-03T15:46:30Z

💔 Test failed - status-taskcluster

jdm · 2020-06-03T15:53:09Z

It makes no sense to me that your local build does not reproduce this build error. My only advice at this point is to do the following:

make a build error occur in one of gpuadapter.rs by removing an argument from one of the trait methods
using the path to the generated file that is present in the error message you receive, find the generated UnionTypes.rs that is in the generated bindings' parent directory
gist that file so we can better understand if GPULoadOpOrRangeEnforcedUnsignedLong is actually present or not

kunalmohan · 2020-06-03T16:23:08Z

@jdm https://gist.github.com/kunalmohan/59b4c4dc2beb3fb789da2ed2507a9bcf

kvark

Looks great! I have a few questions, no blocking concerns.

components/script/dom/gpucomputepassencoder.rs

components/script/dom/gpurenderpassencoder.rs

jdm · 2020-06-03T16:50:12Z

Super weird. I built your branch locally and don't see the build error. What OS are you using? I'm on macOS, and it builds successfully with both python 2 and python 3.

jdm · 2020-06-03T16:52:13Z

@bors-servo try=mac retry

bors-servo · 2020-06-03T16:52:19Z

⌛ Trying commit 4b6316c with merge 4a17df6...

@kvark

Implement GPURenderPassEncoder Add webidls for GPURenderPassEncoder and GPURenderEncoderBase and implement relevant methods.  r?@kvark ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___

kunalmohan · 2020-06-03T16:57:44Z

I am on Ubuntu 18.04. I haven't tried building with python3.

bors-servo · 2020-06-03T17:19:19Z

☀️ Test successful - status-taskcluster
State: approved= try=True

jdm · 2020-06-03T17:32:03Z

As a possible workaround, does anything change if you make a typedef for that union and import the typedef name in rust instead?

Add webidls for GPURenderPassEncoder and GPURenderEncoderBase and implement relevant methods.

kunalmohan · 2020-06-03T19:02:32Z

I have modified that particular type to use typedef, as suggested, to check if the build succeeds.
I haven't yet addressed all the comments from the review yet- wgpu-core is yet to be updated- so please don't merge.

kunalmohan · 2020-06-03T19:47:13Z

So build succeeds now \o/. I don't know why that particular type was throwing the error while the other two didn't (Maybe it was cursed :P).
I'll proceed with this if that's not a problem, and push the other changes too.

kunalmohan · 2020-06-03T19:52:15Z

@kvark PTAL!

jdm · 2020-06-03T20:03:28Z

@bors-servo r=kvark

bors-servo · 2020-06-03T20:03:29Z

📌 Commit 3b5ede1 has been approved by kvark

bors-servo · 2020-06-03T23:32:47Z

⌛ Testing commit 3b5ede1 with merge 643c614...

@kvark

Implement GPURenderPassEncoder Add webidls for GPURenderPassEncoder and GPURenderEncoderBase and implement relevant methods.  r?@kvark ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___

bors-servo · 2020-06-04T00:16:33Z

💔 Test failed - status-taskcluster

jdm · 2020-06-04T01:56:00Z

@bors-servo retry

bors-servo · 2020-06-04T01:56:05Z

⌛ Testing commit 3b5ede1 with merge 0281ace...

bors-servo · 2020-06-04T02:39:31Z

☀️ Test successful - status-taskcluster
Approved by: kvark
Pushing 0281ace to master...

highfive assigned kvark Jun 3, 2020

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 3, 2020

highfive added the S-tests-failed The changes caused existing tests to fail. label Jun 3, 2020

kvark approved these changes Jun 3, 2020

View reviewed changes

Implement GPURenderPassEncoder

1d4efb4

Add webidls for GPURenderPassEncoder and GPURenderEncoderBase and implement relevant methods.

kunalmohan force-pushed the gpu-render-pass branch from 4b6316c to 1d4efb4 Compare June 3, 2020 19:01

highfive removed the S-tests-failed The changes caused existing tests to fail. label Jun 3, 2020

Update wgpu-core and wgpu-types

3b5ede1

kunalmohan added this to In progress in WebGPU MVP via automation Jun 3, 2020

kvark approved these changes Jun 3, 2020

View reviewed changes

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 3, 2020

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jun 4, 2020

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jun 4, 2020

bors-servo merged commit 0281ace into servo:master Jun 4, 2020

WebGPU MVP automation moved this from In progress to Done Jun 4, 2020

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 4, 2020

kunalmohan deleted the gpu-render-pass branch June 4, 2020 04:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement GPURenderPassEncoder #26769

Implement GPURenderPassEncoder #26769

kunalmohan commented Jun 3, 2020

highfive commented Jun 3, 2020

highfive commented Jun 3, 2020

kunalmohan commented Jun 3, 2020

jdm commented Jun 3, 2020

bors-servo commented Jun 3, 2020

bors-servo commented Jun 3, 2020

jdm commented Jun 3, 2020

kunalmohan commented Jun 3, 2020

kvark left a comment

jdm commented Jun 3, 2020 •

edited

jdm commented Jun 3, 2020

bors-servo commented Jun 3, 2020

kunalmohan commented Jun 3, 2020 •

edited

bors-servo commented Jun 3, 2020

jdm commented Jun 3, 2020

kunalmohan commented Jun 3, 2020

kunalmohan commented Jun 3, 2020

kunalmohan commented Jun 3, 2020

jdm commented Jun 3, 2020

bors-servo commented Jun 3, 2020

bors-servo commented Jun 3, 2020

bors-servo commented Jun 4, 2020

jdm commented Jun 4, 2020

bors-servo commented Jun 4, 2020

bors-servo commented Jun 4, 2020

Implement GPURenderPassEncoder #26769

Implement GPURenderPassEncoder #26769

Conversation

kunalmohan commented Jun 3, 2020

highfive commented Jun 3, 2020

highfive commented Jun 3, 2020

kunalmohan commented Jun 3, 2020

jdm commented Jun 3, 2020

bors-servo commented Jun 3, 2020

bors-servo commented Jun 3, 2020

jdm commented Jun 3, 2020

kunalmohan commented Jun 3, 2020

kvark left a comment

Choose a reason for hiding this comment

jdm commented Jun 3, 2020 • edited

jdm commented Jun 3, 2020

bors-servo commented Jun 3, 2020

kunalmohan commented Jun 3, 2020 • edited

bors-servo commented Jun 3, 2020

jdm commented Jun 3, 2020

kunalmohan commented Jun 3, 2020

kunalmohan commented Jun 3, 2020

kunalmohan commented Jun 3, 2020

jdm commented Jun 3, 2020

bors-servo commented Jun 3, 2020

bors-servo commented Jun 3, 2020

bors-servo commented Jun 4, 2020

jdm commented Jun 4, 2020

bors-servo commented Jun 4, 2020

bors-servo commented Jun 4, 2020

jdm commented Jun 3, 2020 •

edited

kunalmohan commented Jun 3, 2020 •

edited