Compute content sizes lazily in layout 2020 #26968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
|
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jun 18, 2020
Compute content sizes lazily in layout 2020
|
☀️ Test successful - status-taskcluster |
SimonSapin
reviewed
Jun 18, 2020
| @@ -144,10 +134,40 @@ impl IndependentFormattingContext { | |||
| } | |||
| } | |||
|
|
|||
| pub fn content_sizes(&self) -> ContentSizes { | |||
| pub fn outer_inline( | |||
There was a problem hiding this comment.
Nit: please rename this to outer_inline_content_sizes, and similarly the next method
| let container = BlockContainer::InlineFormattingContext( | ||
| builder.ongoing_inline_formatting_context, | ||
| ); | ||
| return (container, builder.contains_floats, content_sizes); | ||
| return (container, builder.contains_floats); | ||
| } | ||
| builder.end_ongoing_inline_formatting_context(); | ||
| } | ||
|
|
||
| struct Accumulator { |
There was a problem hiding this comment.
Maybe remove this struct and use let mut contains_floats instead?
components/layout_2020/flow/mod.rs
Outdated
| match &self { | ||
| Self::BlockLevelBoxes(boxes) => { | ||
| let mut content_sizes = ContentSizes::zero(); | ||
| for box_ in boxes { |
There was a problem hiding this comment.
Can we parallelize this loop with rayon?
|
I took the liberty of pushing to your branch. I’d like to land it in order to rebase another branch on top of it. @bors-servo r+ |
|
📌 Commit 42e9d24 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
added a commit
that referenced
this pull request
Jun 19, 2020
…apin Compute content sizes lazily in layout 2020
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
bors-servo
added a commit
that referenced
this pull request
Jun 19, 2020
…apin Compute content sizes lazily in layout 2020
highfive
added
S-awaiting-merge
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
|
@bors-servo retry #26895 |
highfive
added
S-awaiting-merge
|
☀️ Test successful - status-taskcluster |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.