Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Implement HTMLCanvasElement.captureStream #27258

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] Implement HTMLCanvasElement.captureStream #27258

wants to merge 5 commits into from

Conversation

ferjm
Copy link
Contributor

@ferjm ferjm commented Jul 14, 2020

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/HTMLCanvasElement.webidl, components/script/dom/htmlcanvaselement.rs, components/script/dom/mediadevices.rs
  • @KiChjang: components/script/dom/webidls/HTMLCanvasElement.webidl, components/script/dom/htmlcanvaselement.rs, components/script/dom/mediadevices.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 14, 2020
@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@ferjm ferjm marked this pull request as draft July 14, 2020 13:07
@ferjm
Copy link
Contributor Author

ferjm commented Jul 14, 2020

Currently affected by #27259

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #27265) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Jul 15, 2020
@ferjm ferjm force-pushed the canvas.capturestream branch 2 times, most recently from d4a27db to 6ce5800 Compare July 28, 2020 10:21
@ferjm
Copy link
Contributor Author

ferjm commented Jul 30, 2020

Blocked on #27425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement HTMLCanvasElement.captureStream
4 participants
@ferjm @highfive @bors-servo @nox