Allow mutating <input disabled type=checkbox/radio> #27666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
approved these changes
Sep 24, 2020
Comment on lines
2739
to
2742
| if !self.is_mutable() && | ||
| self.input_type() != InputType::Checkbox && | ||
| self.input_type() != InputType::Radio | ||
| { |
There was a problem hiding this comment.
Based on https://html.spec.whatwg.org/multipage/input.html#the-input-element:legacy-pre-activation-behavior it looks like this entire check can be removed instead.
Comment on lines
2780
to
2783
| if !self.is_mutable() && | ||
| self.input_type() != InputType::Checkbox && | ||
| self.input_type() != InputType::Radio | ||
| { |
jdm
added
the
S-needs-code-changes
|
@bors-servo r+ |
|
📌 Commit 15376d0 has been approved by |
bors-servo
added a commit
that referenced
this pull request
Sep 24, 2020
Allow mutating <input disabled type=checkbox/radio> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #27586 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
💔 Test failed - status-taskcluster |
|
@bors-servo retry
|
|
☀️ Test successful - status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors