Implements StyleSheet.media #27697
Merged
Implements StyleSheet.media #27697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CYBAI
reviewed
Oct 11, 2020
Comment on lines
106
to
110
| return MediaList::new( | ||
| self.global().as_window(), | ||
| self, | ||
| self.style_stylesheet().media.clone(), | ||
| ); |
There was a problem hiding this comment.
You can return it directly without specifying return explicitly in this case.
Suggested change
| return MediaList::new( | |
| self.global().as_window(), | |
| self, | |
| self.style_stylesheet().media.clone(), | |
| ); | |
| MediaList::new( | |
| self.global().as_window(), | |
| self, | |
| self.style_stylesheet().media.clone(), | |
| ) |
ghostd
force-pushed
the
stylesheet-media
branch
from
348e666
to
7092f23
Compare
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Oct 11, 2020
Implements StyleSheet.media <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
💔 Test failed - status-taskcluster |
ghostd
force-pushed
the
stylesheet-media
branch
from
7092f23
to
759570f
Compare
CYBAI
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
I can't r+ though, this looks good to me! Thanks for your contribution!
I was only concerned about if we can unwrap the downcast directly in self.downcast::<CSSStyleSheet>().unwrap().medialist(); with reading the spec, it seems we should always be able to downcast in the case. 👀 so, LGTM!
|
@bors-servo try=wpt-2020 |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Oct 15, 2020
Implements StyleSheet.media <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Oct 15, 2020
Implements StyleSheet.media <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
jdm
added
the
S-needs-code-changes
|
💔 Test failed - status-taskcluster |
|
These test results for layout-2020 need to be updated: |
ghostd
force-pushed
the
stylesheet-media
branch
from
759570f
to
fe82d17
Compare
|
Test results updated and rebased onto master |
|
@bors-servo try
|
bors-servo
added a commit
that referenced
this pull request
Oct 16, 2020
Implements StyleSheet.media <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
CYBAI
added
S-awaiting-merge
|
💔 Test failed - status-taskcluster |
|
Cool! There are more PASS tests for media query! You can run following commands to update test expectations for the file locally 👇 Open to see PASS tests |
ghostd
force-pushed
the
stylesheet-media
branch
from
fe82d17
to
f1886c4
Compare
ghostd
force-pushed
the
stylesheet-media
branch
from
f1886c4
to
66223f7
Compare
|
Updated. Thanks for the "auto update" :-) |
|
@bors-servo try
|
bors-servo
added a commit
that referenced
this pull request
Oct 16, 2020
Implements StyleSheet.media <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
💔 Test failed - status-taskcluster |
|
The linux build seems fine, but the Mac OS build has failed. |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Oct 16, 2020
Implements StyleSheet.media <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
☀️ Test successful - status-taskcluster |
|
@bors-servo r+ |
|
📌 Commit 66223f7 has been approved by |
|
☀️ Test successful - status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors