Fix some 'nosniff' tests #27851
Merged
Fix some 'nosniff' tests #27851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Nov 26, 2020
Fix some 'nosniff' tests This PR implements some standard function to work with headers, hence it fixes some 'nosniff' test/ I create a PR as Draft because i have some questions: * i added the code info the `net` module instead of `script::dom::headers` to avoid some cyclic dependencies... but i'm not sure about this choice. Is there another potential location to put this code? * i used String object to match the spectification (it states to collect sequences of "code points", but some code use byte arrays. Should i change the code to work with bytes? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
☀️ Test successful - status-taskcluster |
agniutkarsh
approved these changes
Dec 1, 2020
|
☔ The latest upstream changes (presumably #27962) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I rebased onto master. I think i'll needs these changes for future works. |
|
@bors-servo r+ |
|
📌 Commit 3b38240 has been approved by |
highfive
added
S-awaiting-merge
|
☀️ Test successful - status-taskcluster |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements some standard function to work with headers, hence it fixes some 'nosniff' test/
I create a PR as Draft because i have some questions:
netmodule instead ofscript::dom::headersto avoid some cyclic dependencies... but i'm not sure about this choice. Is there another potential location to put this code?./mach build -ddoes not report any errors./mach test-tidydoes not report any errors