Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync WPT with upstream manually (20-01-2022) #28700

Merged
merged 1 commit into from Feb 12, 2022

Conversation

CYBAI
Copy link
Member

@CYBAI CYBAI commented Jan 20, 2022

This is a follow-up for #28592. Because we still have a gap to sync from 2021/09/07, I'd like to merge this one and try to fix the nightly sync action PR. 🙏

@CYBAI
Copy link
Member Author

CYBAI commented Jan 20, 2022

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

⌛ Trying commit f2e10e6 with merge 6b11e97...

bors-servo added a commit that referenced this pull request Jan 20, 2022
Sync WPT with upstream manually (20-01-2022)

This is a follow-up for #28592. Because we still have a gap to sync from 2021/09/07, I'd like to merge this one and try to fix the nightly sync action PR. 🙏
@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1642654642907.

@bors-servo
Copy link
Contributor

💔 Test failed - checks-github

@CYBAI
Copy link
Member Author

CYBAI commented Jan 20, 2022

@bors-servo try=wpt

We had only one failure which is

  ▶ FAIL [expected TIMEOUT] b'/css/css-flexbox/flexbox-writing-mode-013.html'
  │   → /css/css-flexbox/flexbox-writing-mode-013.html ['62d2f5d4af8d1058a66dc66218de0c479894ab54']
  └   → /css/css-flexbox/flexbox-writing-mode-013-ref.html ['f753db8e4ce4f4b4f48a6d9059fca8c6708d0a1d']

and I think it was an intermittent TIMEOUT in the update so I filed #28701.

Let's try again!

bors-servo added a commit that referenced this pull request Jan 20, 2022
Sync WPT with upstream manually (20-01-2022)

This is a follow-up for #28592. Because we still have a gap to sync from 2021/09/07, I'd like to merge this one and try to fix the nightly sync action PR. 🙏
@bors-servo
Copy link
Contributor

⌛ Trying commit b77ad11 with merge 3a6306e...

@servo-wpt-sync
Copy link
Collaborator

Error syncing changes upstream. Logs saved in error-snapshot-1642680016609.

@bors-servo
Copy link
Contributor

💔 Test failed - checks-github

@CYBAI
Copy link
Member Author

CYBAI commented Jan 20, 2022

@bors-servo retry

hmm, let me retry to see if it's an intermittent ERROR 🤔

  ▶ ERROR [expected OK] b'/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-url.html'
  │   → import.meta may only appear in a module
  │ 
  └ http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/module/import-meta/postmessage-worker.js?DedicatedWorker:3:21

@bors-servo
Copy link
Contributor

⌛ Trying commit b77ad11 with merge 001f296...

bors-servo added a commit that referenced this pull request Jan 20, 2022
Sync WPT with upstream manually (20-01-2022)

This is a follow-up for #28592. Because we still have a gap to sync from 2021/09/07, I'd like to merge this one and try to fix the nightly sync action PR. 🙏
@bors-servo
Copy link
Contributor

💔 Test failed - checks-github

@CYBAI
Copy link
Member Author

CYBAI commented Jan 21, 2022

^ WPT passed.

but macOS build failed at mozjs 🤔 It passed in the first try of this PR though, is it an intermittent build fail? 👀

error: failed to run custom build command for `mozjs_sys v0.68.2 (https://github.com/servo/mozjs?rev=4cd3f5b81f4c363c039631bf870e61a00c983f63#4cd3f5b8)`

Caused by:
  process didn't exit successfully: `/Users/runner/work/servo/servo/target/release/build/mozjs_sys-fa46ef939b468b63/build-script-build` (exit status: 101)

@CYBAI
Copy link
Member Author

CYBAI commented Jan 21, 2022

r? @jdm

@CYBAI CYBAI added the S-awaiting-review There is new code that needs to be reviewed. label Jan 21, 2022
@jdm
Copy link
Member

jdm commented Jan 21, 2022

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit b77ad11 has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit b77ad11 with merge 2834cf1...

bors-servo added a commit that referenced this pull request Jan 21, 2022
Sync WPT with upstream manually (20-01-2022)

This is a follow-up for #28592. Because we still have a gap to sync from 2021/09/07, I'd like to merge this one and try to fix the nightly sync action PR. 🙏
@bors-servo
Copy link
Contributor

💔 Test failed - checks-github

@jdm
Copy link
Member

jdm commented Jan 21, 2022

Huh, it happened again:

  Creating Python 3 environment
  Traceback (most recent call last):
    File "/Users/runner/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/4cd3f5b/mozjs/third_party/python/virtualenv/virtualenv.py", line 56, in <module>
      run()
    File "/Users/runner/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/4cd3f5b/mozjs/third_party/python/virtualenv/virtualenv.py", line 50, in run
      from virtualenv.__main__ import run as run_virtualenv
    File "/Users/runner/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/4cd3f5b/mozjs/third_party/python/virtualenv/virtualenv/__init__.py", line 3, in <module>
      from .run import cli_run, session_via_cli
    File "/Users/runner/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/4cd3f5b/mozjs/third_party/python/virtualenv/virtualenv/run/__init__.py", line 13, in <module>
      from .plugin.creators import CreatorSelector
    File "/Users/runner/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/4cd3f5b/mozjs/third_party/python/virtualenv/virtualenv/run/plugin/creators.py", line 6, in <module>
      from virtualenv.create.via_global_ref.builtin.builtin_way import VirtualenvBuiltin
    File "/Users/runner/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/4cd3f5b/mozjs/third_party/python/virtualenv/virtualenv/create/via_global_ref/builtin/builtin_way.py", line 7, in <module>
      from virtualenv.create.creator import Creator
    File "/Users/runner/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/4cd3f5b/mozjs/third_party/python/virtualenv/virtualenv/create/creator.py", line 15, in <module>
      from virtualenv.discovery.cached_py_info import LogCmd
    File "/Users/runner/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/4cd3f5b/mozjs/third_party/python/virtualenv/virtualenv/discovery/cached_py_info.py", line 16, in <module>
      from virtualenv.discovery.py_info import PythonInfo
    File "/Users/runner/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/4cd3f5b/mozjs/third_party/python/virtualenv/virtualenv/discovery/py_info.py", line 16, in <module>
      from distutils import dist
    File "/Users/runner/work/servo/servo/python/_virtualenv3.9/lib/python3.9/site-packages/_distutils_hack/__init__.py", line 83, in create_module
      return importlib.import_module('setuptools._distutils')
    File "/usr/local/Cellar/python@3.9/3.9.10/Frameworks/Python.framework/Versions/3.9/lib/python3.9/importlib/__init__.py", line 127, in import_module
      return _bootstrap._gcd_import(name[level:], package, level)
  ModuleNotFoundError: No module named 'setuptools'
  DEBUG: python3: running with pid 41180
  DEBUG: python3: sys.executable: '/Users/runner/work/servo/servo/python/_virtualenv3.9/bin/python3'
  DEBUG: python3: executable from configuration: None
  DEBUG: python3: found executable: '/Users/runner/work/servo/servo/python/_virtualenv3.9/bin/python3'

And we install setuptools in

setuptools == 50.3.2

@jdm
Copy link
Member

jdm commented Feb 11, 2022

@bors-servo r-

bors-servo added a commit that referenced this pull request Feb 11, 2022
Sync WPT with upstream manually (20-01-2022)

This is a follow-up for #28592. Because we still have a gap to sync from 2021/09/07, I'd like to merge this one and try to fix the nightly sync action PR. 🙏
@bors-servo
Copy link
Contributor

⌛ Testing commit b77ad11 with merge f8a6483...

@bors-servo
Copy link
Contributor

💔 Test failed - checks-github

@CYBAI
Copy link
Member Author

CYBAI commented Feb 11, 2022

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

@CYBAI: 🔑 Insufficient privileges: Not in reviewers

@jdm
Copy link
Member

jdm commented Feb 11, 2022

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit b77ad11 has been approved by jdm

bors-servo added a commit that referenced this pull request Feb 11, 2022
Sync WPT with upstream manually (20-01-2022)

This is a follow-up for #28592. Because we still have a gap to sync from 2021/09/07, I'd like to merge this one and try to fix the nightly sync action PR. 🙏
@bors-servo
Copy link
Contributor

⌛ Testing commit b77ad11 with merge 75011b9...

@bors-servo
Copy link
Contributor

💔 Test failed - checks-github

@CYBAI
Copy link
Member Author

CYBAI commented Feb 12, 2022

@bors-servo
Copy link
Contributor

⌛ Testing commit b77ad11 with merge d551e63...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
Approved by: jdm
Pushing d551e63 to master...

@bors-servo bors-servo merged commit d551e63 into servo:master Feb 12, 2022
@CYBAI CYBAI deleted the wpt_update_20-01-2022 branch February 13, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-awaiting-review There is new code that needs to be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants