-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the WPT export script #29601
Fix the WPT export script #29601
Conversation
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
1 similar comment
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
26a824f
to
1184341
Compare
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
1 similar comment
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
1184341
to
c27491c
Compare
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
1 similar comment
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
c27491c
to
0e204d8
Compare
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#39426) with upstreamable changes. |
6c308ee
to
9abf127
Compare
ef9daf6
to
75faafa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good, with one question.
- Have the WPT exporter script use the WPT_SYNC_TOKEN for checking out wpt. - Make sure the local WPT repository is unshallow when pushing. - When searching for existing PRs use the main GitHub search API, as the pull request search does not seem to properly process the "head" parameter. - When deleting branches in the downstream WPT repository, use the full URL to avoid trying to modify the upstream repository.
75faafa
to
f4b5b9f
Compare
@bors-servo r=delan @delan Thank you for the review! |
📌 Commit f4b5b9f has been approved by |
Fix the WPT export script - Have the WPT exporter script use the WPT_SYNC_TOKEN for checking out wpt. - Make sure the local WPT repository is unshallow when pushing. - When searching for existing PRs use the main GitHub search API, as the pull request search does not seem to properly process the "head" parameter. - When deleting branches in the downstream WPT repository, use the full URL to avoid trying to modify the upstream repository. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes OR <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Results from try job (#4667551111): Flaky unexpected result (23)
Stable unexpected results that are known to be intermittent (24)
Stable unexpected results (1)
|
@bors-servo retry |
Results from try job (#4668932585): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (28)
|
☀️ Test successful - checks-github |
wpt.
as the pull request search does not seem to properly process
the "head" parameter.
the full URL to avoid trying to modify the upstream repository.
./mach build -d
does not report any errors./mach test-tidy
does not report any errors