Make errors during build status notification warnings #29638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of raising an exception, simply print a warning on stderr when notification fails. Fixes servo#29635.
|
@bors-servo r+ |
|
📌 Commit 61a70fb has been approved by |
bors-servo
added a commit
that referenced
this pull request
Apr 17, 2023
Make errors during build status notification warnings Instead of raising an exception, simply print a warning on stderr when notification fails. Fixes #29635. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29635 - [x] These changes do not require tests because they fix a minor tools issue. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Results from try job (#4718869766): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (17)
Stable unexpected results (1)
|
|
@bors-servo retry |
|
Results from try job (#4719443487): Flaky unexpected result (23)
Stable unexpected results that are known to be intermittent (22)
|
|
☀️ Test successful - checks-github |
1 similar comment
|
☀️ Test successful - checks-github |
|
Results from try job (#4721659781): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (23)
|
|
Results from try job (#4727871800): Flaky unexpected result (22)
Stable unexpected results that are known to be intermittent (23)
|
|
Results from try job (#4728927955): Flaky unexpected result (23)
Stable unexpected results that are known to be intermittent (21)
Stable unexpected results (1)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of raising an exception, simply print a warning on stderr when notification fails.
Fixes #29635.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors./mach build -d#29635