Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent failure in /_mozilla/mozilla/scrollBy.html #21321

Closed
jdm opened this issue Aug 2, 2018 · 0 comments · Fixed by #29680
Closed

Intermittent failure in /_mozilla/mozilla/scrollBy.html #21321

jdm opened this issue Aug 2, 2018 · 0 comments · Fixed by #29680
Labels
I-intermittent Problem reproduces intermittently.

Comments

@jdm
Copy link
Member

jdm commented Aug 2, 2018 

  ▶ Unexpected subtest result in /_mozilla/mozilla/scrollBy.html:
  │ FAIL [expected PASS] Ensure that the window.scrollBy function affects scroll position as expected
  │   → assert_equals: expected Element node <html><head><meta charset="utf-8">
<title>Ensure that the... but got Element node <a id="link" href="http://mozilla.org">This is some link ...
  │ 
  │ @http://web-platform.test:8000/_mozilla/mozilla/scrollBy.html:21:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1538:20
  │ test@http://web-platform.test:8000/resources/testharness.js:545:9
  └ @http://web-platform.test:8000/_mozilla/mozilla/scrollBy.html:10:5
@jdm jdm added the I-intermittent Problem reproduces intermittently. label Aug 2, 2018
@jdm jdm mentioned this issue Aug 2, 2018
Merged
@nox nox mentioned this issue Aug 3, 2018
Merged
@jdm jdm mentioned this issue Aug 3, 2018
Closed
This was referenced Feb 16, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Feb 25, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 25, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@mrobinson mrobinson mentioned this issue Apr 28, 2023
Merged
4 tasks
bors-servo added a commit that referenced this issue Apr 28, 2023
@bors-servo
Auto merge of #29680 - mrobinson:fix-root-scrolling-area, r=<try>
66c9890 
Fix scrolls run on the `window` object from script

The calculation of the viewport scrolling area was incorrect, because it was based on the body element instead of the viewport. This change makes the argument to the layout query optional and when it is not specified, the return value reflects the viewport's scrolling area.

In addition, scrolling the window object early on in the page load could sometimes lead to a situation where WebRender would scroll, but not request a frame with the scrolled content. Always request a frame when updating scroll positions from script.

This patch was written in collaboration with Rakhi Sharma <atbrakhi@igalia.com>.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21321.
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This was referenced Apr 28, 2023
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 5, 2023
Merged
Merged
Closed
Merged
Merged
@github-actions github-actions bot mentioned this issue Sep 8, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-intermittent Problem reproduces intermittently.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor scrolling on the window object mrobinson/servo
1 participant
@jdm