Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect some tests to fail in layout-2020 #29667

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

Loirooriol
Copy link
Contributor

sslfail.html and websocket_disconnect.html are already expected to fail in layout-2013.

text-indent-percentage-001.xht and text-indent-tab-positions-001.html fail in layout-2020 due to lack of support for text-indent and tabs.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because they are just updating test expectations.

sslfail.html and websocket_disconnect.html are already expected to fail
in layout-2013.

text-indent-percentage-001.xht and text-indent-tab-positions-001.html
fail in layout-2020 due to lack of support for text-indent and tabs.
@Loirooriol
Copy link
Contributor Author

@bors-servo try=wpt-2020

@bors-servo
Copy link
Contributor

⌛ Trying commit 10cdaef with merge d5e874e...

bors-servo added a commit that referenced this pull request Apr 25, 2023
Expect some tests to fail in layout-2020

sslfail.html and websocket_disconnect.html are already expected to fail in layout-2013.

text-indent-percentage-001.xht and text-indent-tab-positions-001.html fail in layout-2020 due to lack of support for text-indent and tabs.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are just updating test expectations.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@github-actions
Copy link

Results from try job (#4800711604):

Flaky unexpected result (6)
  • FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
  • OK /_mozilla/mozilla/hit-test-background.html (#22942)
    • FAIL [expected PASS] subtest: Hit testing backgrounds of content should report the same element as the content
  • OK /css/CSS2/floats/hit-test-floats-005.html (#25804)
    • PASS [expected FAIL] subtest: Miss clipped float
  • OK /css/css-flexbox/hittest-anonymous-box.html (#27091)
    • PASS [expected FAIL] subtest: Hit-testing within an anonymous flex-item should return the flexbox as the hittest result.
  • OK /css/css-transforms/transform-scale-hittest.html (#24667)
    • FAIL [expected PASS] subtest: Hit test within unscaled box
  • OK /css/cssom-view/elementFromPoint-002.html
    • PASS [expected FAIL] subtest: Checking whether dynamic changes to visibility interact correctly with
      table anonymous boxes
Stable unexpected results that are known to be intermittent (11)
  • OK /_mozilla/mozilla/scrollBy.html (#21321)
    • FAIL [expected PASS] subtest: Ensure that the window.scrollBy function affects scroll position as expected
  • OK /css/CSS2/floats/hit-test-floats-001.html (#23693)
    • FAIL [expected PASS] subtest: hit-test-floats-001
  • OK /css/CSS2/floats/hit-test-floats-003.html (#25733)
    • PASS [expected FAIL] subtest: Miss float below something else
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-float-001.html (#29565)
    • FAIL [expected PASS] subtest: block-in-inline-hittest-float-001
  • OK /css/css-transitions/properties-value-001.html (#21486)
    • PASS [expected FAIL] subtest: background-color color(rgba) / values
    • PASS [expected FAIL] subtest: border-top-width length(pt) / values
    • PASS [expected FAIL] subtest: border-top-width length(pc) / values
    • PASS [expected FAIL] subtest: border-top-width length(px) / values
    • PASS [expected FAIL] subtest: border-top-width length(em) / values
    • PASS [expected FAIL] subtest: border-top-width length(ex) / values
    • PASS [expected FAIL] subtest: border-top-width length(mm) / values
    • PASS [expected FAIL] subtest: border-top-width length(cm) / values
    • PASS [expected FAIL] subtest: border-top-width length(in) / values
    • PASS [expected FAIL] subtest: border-right-width length(pt) / values
    • And 31 more unexpected results...
  • OK /css/css-transitions/properties-value-inherit-001.html (#21486)
    • PASS [expected FAIL] subtest: background-color color(rgba) / events
    • PASS [expected FAIL] subtest: border-top-width length(pt) / events
    • PASS [expected FAIL] subtest: border-top-width length(pc) / events
    • PASS [expected FAIL] subtest: border-top-width length(px) / events
    • PASS [expected FAIL] subtest: border-top-width length(em) / events
    • PASS [expected FAIL] subtest: border-top-width length(ex) / events
    • PASS [expected FAIL] subtest: border-top-width length(mm) / events
    • PASS [expected FAIL] subtest: border-top-width length(cm) / events
    • PASS [expected FAIL] subtest: border-top-width length(in) / events
    • PASS [expected FAIL] subtest: border-right-width length(pt) / events
    • And 31 more unexpected results...
  • OK /css/cssom-view/elementFromPoint-ellipsis-in-inline-box.html (#27414)
    • FAIL [expected PASS] subtest: elementFromPoint-ellipsis-in-inline-box
  • OK /css/cssom-view/elementFromPoint-float-in-relative.html (#27753)
    • FAIL [expected PASS] subtest: elementFromPoint-float-in-relative
  • OK /css/cssom-view/elementFromPoint-float-in-table.html (#27002)
    • PASS [expected FAIL] subtest: float-in-div
  • OK /css/cssom-view/elementFromPosition.html (#21295)
    • PASS [expected FAIL] subtest: test some point of the element: top left corner
  • OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
    • FAIL [expected PASS] subtest: Instant scrolling while doing history navigation.

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
State: approved= try=True

@mrobinson
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 10cdaef has been approved by mrobinson

@bors-servo
Copy link
Contributor

⌛ Testing commit 10cdaef with merge e74b5a1...

@github-actions
Copy link

Results from try job (#4801370208):

Flaky unexpected result (17)
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
    • NOTRUN [expected PASS] subtest: Overall test
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
    • NOTRUN [expected PASS] subtest: Overall test
  • TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
    • NOTRUN [expected PASS] subtest: Overall test
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-002.html (#29057)
    • FAIL [expected PASS] subtest: elementFromPoint
  • OK /css/css-flexbox/hittest-anonymous-box.html (#27091)
    • FAIL [expected PASS] subtest: Hit-testing within an anonymous flex-item should return the flexbox as the hittest result.
  • OK /css/cssom-view/elementFromPoint-dynamic-anon-box.html (#22337)
    • PASS [expected FAIL] subtest: Link should be clickable after hiding a scrollbox with an anonymous table inside
  • TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
    • TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
  • ERROR [expected TIMEOUT] /html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin.html (#28541)
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
    • PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
  • TIMEOUT [expected CRASH] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
    • TIMEOUT [expected FAIL] subtest: opener of discarded auxiliary browsing context
  • TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
    • TIMEOUT [expected FAIL] subtest: Element with tabindex should support autofocus
    • NOTRUN [expected PASS] subtest: Non-HTMLElement should not support autofocus
    • NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
    • NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
    • NOTRUN [expected FAIL] subtest: Area element should support autofocus
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
    • TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
      allow-popups-to-escape-sandbox is used
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
    • NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
    • FAIL [expected PASS] subtest: createHTMLDocument
    • FAIL [expected PASS] subtest: <template>
  • OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
    • PASS [expected FAIL] subtest: multipart/form-data: 0x00 in value (formdata event)
  • TIMEOUT [expected OK] /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
    • NOTRUN [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
    • NOTRUN [expected FAIL] subtest: Check that rel=noopener with target=_parent does a normal load
    • NOTRUN [expected FAIL] subtest: Check that rel=noopener with target=_top does a normal load
  • OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
Stable unexpected results that are known to be intermittent (25)
  • OK /_mozilla/mozilla/scrollBy.html (#21321)
    • PASS [expected FAIL] subtest: Ensure that the window.scrollBy function affects scroll position as expected
  • OK /css/CSS2/floats/hit-test-floats-001.html (#23693)
    • PASS [expected FAIL] subtest: hit-test-floats-001
  • OK /css/CSS2/linebox/inline-negative-margin-001.html (#23862)
    • PASS [expected FAIL] subtest: [data-expected-height] 1
    • PASS [expected FAIL] subtest: [data-expected-height] 2
    • FAIL [expected PASS] subtest: [data-expected-height] 4
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-float-001.html (#29565)
    • PASS [expected FAIL] subtest: block-in-inline-hittest-float-001
  • OK /css/CSS2/normal-flow/block-in-inline-hittest-float-002.html (#29051)
    • FAIL [expected PASS] subtest: block-in-inline-hittest-float-002
  • OK /css/css-transitions/properties-value-inherit-002.html (#21486)
    • PASS [expected FAIL] subtest: color color(rgba) / values
    • PASS [expected FAIL] subtest: font-size length(pt) / values
    • PASS [expected FAIL] subtest: font-size length(pc) / values
    • PASS [expected FAIL] subtest: font-size length(px) / values
    • PASS [expected FAIL] subtest: font-size length(em) / values
    • PASS [expected FAIL] subtest: font-size length(ex) / values
    • PASS [expected FAIL] subtest: font-size length(mm) / values
    • PASS [expected FAIL] subtest: font-size length(cm) / values
    • PASS [expected FAIL] subtest: font-size length(in) / values
    • PASS [expected FAIL] subtest: font-size percentage(%) / values
    • And 40 more unexpected results...
  • OK /css/cssom-view/CaretPosition-001.html (#21338)
    • PASS [expected FAIL] subtest: Element at (400, 100)
  • OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
    • PASS [expected FAIL] subtest: listeners are called correct number of times
    • PASS [expected FAIL] subtest: listener that was added twice is called only once
  • OK /css/cssom-view/elementFromPoint-001.html (#22452)
    • FAIL [expected PASS] subtest: CSSOM View - 5 - extensions to the Document interface
  • OK /css/cssom-view/elementFromPoint-ellipsis-in-inline-box.html (#27414)
    • PASS [expected FAIL] subtest: elementFromPoint-ellipsis-in-inline-box
  • OK /css/cssom-view/elementFromPoint-list-001.html (#23915)
    • PASS [expected FAIL] subtest: <li>Inside 1</li>
    • PASS [expected FAIL] subtest: <li>Inside 2</li>
  • TIMEOUT [expected OK] /fetch/api/basic/keepalive.any.html (#29536)
  • TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.any.html (#29536)
  • OK [expected TIMEOUT] /fetch/local-network-access/iframe.tentative.https.window.html (#29605)
    • PASS [expected TIMEOUT] subtest: local to local, grandparent navigates: no preflight required.
    • FAIL [expected TIMEOUT] subtest: public to local, grandparent navigates: failure.
    • FAIL [expected TIMEOUT] subtest: public to local, grandparent navigates: success.
  • TIMEOUT /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-no-beforeunload.window.html (#29055)
    • FAIL [expected TIMEOUT] subtest: Navigating an opened window with an iframe via location.href to a javascript: URL must not fire beforeunload on the iframe: undefined completion
    • PASS [expected NOTRUN] subtest: Navigating an iframe via location.href to a javascript: URL must not fire beforeunload: string completion
    • PASS [expected NOTRUN] subtest: Navigating an iframe via src="" to a javascript: URL after insertion must not fire beforeunload: string completion
    • TIMEOUT [expected NOTRUN] subtest: Navigating an opened window via location.href to a javascript: URL must not fire beforeunload: string completion
  • OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
    • PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
  • OK [expected TIMEOUT] /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
    • PASS [expected TIMEOUT] subtest: first argument: absolute url
  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if
      allow-popups-to-escape-sandbox is used
  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
    • FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
    • PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
  • OK [expected TIMEOUT] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
    • FAIL [expected TIMEOUT] subtest: Sanity check: this all works as expected with no promises involved
    • FAIL [expected TIMEOUT] subtest: Fulfillment handler on fulfilled promise
    • FAIL [expected TIMEOUT] subtest: Fulfillment handler on pending-then-fulfilled promise
  • OK [expected ERROR] /resource-timing/cors-preflight.any.html (#28694)
    • FAIL [expected TIMEOUT] subtest: PerformanceResourceTiming sizes fetch with preflight test
  • CRASH [expected TIMEOUT] /webmessaging/broadcastchannel/cross-partition.https.tentative.html (#29058)
  • TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
    • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
  • OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
    • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
Approved by: mrobinson
Pushing e74b5a1 to master...

@bors-servo bors-servo merged commit e74b5a1 into servo:master Apr 25, 2023
10 checks passed
@Loirooriol Loirooriol deleted the test-failures branch April 25, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants