bump base64 from 0.10 to 0.21 #29804

dvtkrlbs · 2023-05-28T19:14:41Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes partly fix Deduplicate base64 #26013
These changes do not require tests because it bumps version of a dependency. From running the tests there does not seem to be any regressions (there are a lot of crashed tests but I don't think they are relevant to this change)

dvtkrlbs · 2023-05-28T19:18:18Z

I looked at the dependency tree using cargo tree with -i flag and one of the dependencies is content-security-policy and other is headers and they seem reluctant to upgrade base64 based on MSRV concerns. THere is also ron (one for 0.10.1 and one for 0.13 with different ron versions) and webdriver which I did not follow the conversation for base64.

jdm · 2023-05-28T19:22:41Z

@bors-servo r+
Thanks! There's also a new version of content-security-policy released (0.5.1) with a newer base64 which we can update to.

bors-servo · 2023-05-28T19:22:43Z

📌 Commit c554358 has been approved by jdm

bors-servo · 2023-05-28T19:22:45Z

⌛ Testing commit c554358 with merge c698d74...

bump base64 from 0.10 to 0.21  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes partly fix #26013 - [x] These changes do not require tests because it bumps version of a dependency. From running the tests there does not seem to be any regressions (there are a lot of crashed tests but I don't think they are relevant to this change)

jdm · 2023-05-28T19:46:39Z

@bors-servo r+

bors-servo · 2023-05-28T19:46:41Z

📌 Commit 47bd465 has been approved by jdm

bors-servo · 2023-05-28T19:46:44Z

⌛ Testing commit 47bd465 with merge 03725b9...

bump base64 from 0.10 to 0.21  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes partly fix #26013 - [x] These changes do not require tests because it bumps version of a dependency. From running the tests there does not seem to be any regressions (there are a lot of crashed tests but I don't think they are relevant to this change)

dvtkrlbs · 2023-05-28T19:53:03Z

I used cargo update -p content-security-policy to update the lock version. The diff for cargo.lock does not seem to show any changes related to content-security-policy but it seems it got updated.

Cargo.lock

github-actions · 2023-05-28T20:47:01Z

Test results for linux-wpt-layout-2013 from try job (#5106105343):

Flaky unexpected result (23)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/CSS2/linebox/inline-negative-margin-001.html (#23862)
- FAIL [expected PASS] subtest: [data-expected-height] 1 assert_equals:
  <inline-block data-expected-height="10">123 <span style="margin-left: -8ch">1234 </span></inline-block>
  height expected 10 but got 20
- FAIL [expected PASS] subtest: [data-expected-height] 2 assert_equals:
  <inline-block data-expected-height="10">123 <span style="margin-left: -8ch">123 </span></inline-block>
  height expected 10 but got 20
- PASS [expected FAIL] subtest: [data-expected-height] 4
OK [expected TIMEOUT] /fetch/api/basic/keepalive.any.html (#29536)
OK [expected TIMEOUT] /fetch/api/redirect/redirect-keepalive.any.html (#29536)
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent) Test timed out
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
TIMEOUT [expected OK] /html/browsers/browsing-the-web/overlapping-navigations-and-traversals/nav-cancelation-2.sub.html (#29738)
- TIMEOUT [expected FAIL] subtest: grandparent cancels a pending navigation in a cross-origin grandchild Test timed out
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-child-special-cases.tentative.sub.window.html (#29069)
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task Test timed out
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: backslash in name (formdata event)
TIMEOUT [expected OK] /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- NOTRUN [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
OK /html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html (#29137)
- FAIL [expected PASS] subtest: document.write in an imported module assert_true: onload must be called expected true got false
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- PASS [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events.dedicatedworker.html (#28346)
- TIMEOUT [expected FAIL] subtest: delayed handling: delaying handling rejected promise created from createImageBitmap will cause both events to fire Test timed out
ERROR /resource-timing/content-type-parsing.html (#29131)
- FAIL [expected TIMEOUT] subtest: mime-type 16 : text/html;charset=�gbk assert_equals: expected (string) "text/html" but got (undefined) undefined
- TIMEOUT [expected NOTRUN] subtest: mime-type 17 : text/html;charset=gbk Test timed out
OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)

Stable unexpected results that are known to be intermittent (15)

TIMEOUT /fetch/local-network-access/iframe.tentative.https.window.html (#29605)
- TIMEOUT [expected PASS] subtest: local to local, grandparent navigates: no preflight required. Test timed out
- TIMEOUT [expected PASS] subtest: local to local (same-origin), grandparent navigates: no preflight required. Test timed out
OK /fetch/local-network-access/worker-blob-fetch.window.html (#29602)
- FAIL [expected PASS] subtest: local https to local https: success. assert_equals: fetch error expected (undefined) undefined but got (string) "unknown error"
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- FAIL [expected TIMEOUT] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...).show is not a function"
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- FAIL [expected TIMEOUT] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks w.focus is not a function
OK /html/semantics/embedded-content/media-elements/media_fragment_seek.html (#24114)
- PASS [expected FAIL] subtest: Video should seek to time specified in media fragment syntax
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
- PASS [expected FAIL] subtest: createHTMLDocument
- PASS [expected FAIL] subtest: <template>
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- FAIL [expected PASS] subtest: multipart/form-data: 0x00 in name (normal form) assert_equals: expected "\r\nContent-Disposition: form-data; name="a\0b"\r\n\r\nc\r\n--\r\n" but got ""
OK /html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html (#26243)
- PASS [expected FAIL] subtest: document.write in an imported module
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html (#25805)
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise Test timed out
- TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise Test timed out
TIMEOUT /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
- FAIL [expected TIMEOUT] subtest: Sanity check: this all works as expected with no promises involved assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/window-to-open.html" but got "about:blank"
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise Test timed out
- TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise Test timed out
TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
OK /workers/dedicated-worker-from-blob-url.window.html (#22286)
- FAIL [expected PASS] subtest: Creating a dedicated worker from a blob URL works immediately before revoking. promise_test: Unhandled rejection with value: object "[object Event]"

Stable unexpected results (3)

ERROR [expected OK] /html/semantics/embedded-content/the-img-element/image-loading-lazy.html
- NOTRUN [expected FAIL] subtest: Below-viewport blob URL images only load when in the viewport and do not block the window load event
OK /html/webappapis/atob/base64.any.html
- FAIL [expected PASS] subtest: btoa("ab") == "YWI=" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa("abcd") == "YWJjZA==" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa("abcde") == "YWJjZGU=" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa("\0a") == "AGE=" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa(null) == "bnVsbA==" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa(7) == "Nw==" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa(12) == "MTI=" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa(true) == "dHJ1ZQ==" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa(false) == "ZmFsc2U=" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa(Infinity) == "SW5maW5pdHk=" The string contains invalid characters.
- And 273 more unexpected results...
OK /html/webappapis/atob/base64.any.worker.html
- FAIL [expected PASS] subtest: btoa("ab") == "YWI=" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa("abcd") == "YWJjZA==" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa("abcde") == "YWJjZGU=" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa("\0a") == "AGE=" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa(null) == "bnVsbA==" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa(7) == "Nw==" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa(12) == "MTI=" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa(true) == "dHJ1ZQ==" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa(false) == "ZmFsc2U=" The string contains invalid characters.
- FAIL [expected PASS] subtest: btoa(Infinity) == "SW5maW5pdHk=" The string contains invalid characters.
- And 273 more unexpected results...

jdm · 2023-05-28T20:54:33Z

Hmm, we've broken some tests with this change:

OK /html/webappapis/atob/base64.any.html

    FAIL [expected PASS] subtest: btoa("ab") == "YWI=" The string contains invalid characters.
    FAIL [expected PASS] subtest: btoa("abcd") == "YWJjZA==" The string contains invalid characters.
    FAIL [expected PASS] subtest: btoa("abcde") == "YWJjZGU=" The string contains invalid characters.
    FAIL [expected PASS] subtest: btoa("\0a") == "AGE=" The string contains invalid characters.
    FAIL [expected PASS] subtest: btoa(null) == "bnVsbA==" The string contains invalid characters.
    FAIL [expected PASS] subtest: btoa(7) == "Nw==" The string contains invalid characters.
    FAIL [expected PASS] subtest: btoa(12) == "MTI=" The string contains invalid characters.
    FAIL [expected PASS] subtest: btoa(true) == "dHJ1ZQ==" The string contains invalid characters.
    FAIL [expected PASS] subtest: btoa(false) == "ZmFsc2U=" The string contains invalid characters.
    FAIL [expected PASS] subtest: btoa(Infinity) == "SW5maW5pdHk=" The string contains invalid characters.
    And 273 more unexpected results...

To reproduce, run ./mach test-wpt tests/wpt/web-platform-tests/html/webappapis/atob/base64.any.html

dvtkrlbs · 2023-05-28T21:30:42Z

This seems really weird. I did a small test and the encoded string is same byte by byte between the two versions.

dvtkrlbs · 2023-05-28T21:56:07Z

It seems that the actual assert succeeds but there is an additional warning that causes the test to fail. (Clicking on the test case shows the assert itself). Further investigation this seems the test also throws the invalidCharacterError exception. I don't see a clear reason for the code throw this exception.

dvtkrlbs · 2023-06-01T00:02:21Z

I did a few more test using the firefox devtools and the code tested does not seem to cause any problems. Is there an easy way to attach a devtools session to a test-wpt run i could not find a simple flag to be able to attach to the process from firefox ? Other than that I am at a lock here I am not sure about the cause of the regression.

mrobinson · 2023-08-02T12:58:55Z

Trying to unblock this: I pushed a new commit to this branch which adjusts the configuration of the base64 engine to not require padding on decode. I think this fixes the tests.

@bors-servo try=wpt

github-actions · 2023-08-02T12:59:08Z

🔨 Triggering try run (#5739125004) with platform=linux and layout=2013

mrobinson · 2023-08-02T13:30:58Z

@bors-servo try=wpt

github-actions · 2023-08-02T13:31:11Z

🔨 Triggering try run (#5739487511) with platform=linux and layout=2013

github-actions · 2023-08-02T13:45:48Z

Test results for linux-wpt-layout-2013 from try job (#5739125004):

Flaky unexpected result (12)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected FAIL] subtest: Opening a blob URL in a new window immediately before revoking it works. Test timed out
OK /_mozilla/css/stylesheet_media_queries.html (#17159)
- FAIL [expected PASS] subtest: Media queries within stylesheets assert_equals: expected "rgb(0, 255, 0)" but got "rgb(255, 0, 0)"
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
- PASS [expected FAIL] subtest: Instant scrolling while doing history navigation.
- PASS [expected FAIL] subtest: Smooth scrolling while doing history navigation.
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-valid.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with URL fragments should be skipped. Test timed out
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-child-special-cases.tentative.sub.window.html (#29069)
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- FAIL [expected PASS] subtest: Check that rel=noopener with target=_self does a normal load this.openedWindow.findLink is not a function
ERROR /resource-timing/content-type-parsing.html (#29131)
- FAIL [expected TIMEOUT] subtest: mime-type 16 : text/html;charset=�gbk assert_equals: expected (string) "text/html" but got (undefined) undefined
- TIMEOUT [expected NOTRUN] subtest: mime-type 17 : text/html;charset=gbk Test timed out
TIMEOUT /resource-timing/response-status-code.html (#29309)
- TIMEOUT [expected FAIL] subtest: This test validates the response status of resources. 88 Test timed out
- NOTRUN [expected TIMEOUT] subtest: This test validates the response status of resources. 89

Stable unexpected results that are known to be intermittent (12)

OK /_mozilla/mozilla/task_queue_throttling.any.html (#22519)
- FAIL [expected PASS] subtest: Throttling the performance timeline task queue. assert_true: expected true got false
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- PASS [expected TIMEOUT] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/failure-check-sequence.https.html (#28207)
- FAIL [expected TIMEOUT] subtest: CSP check precedes X-Frame-Options check assert_equals: expected (string) "csp-violation" but got (object) null
- FAIL [expected NOTRUN] subtest: CSP check precedes COEP check - CSP header first assert_equals: expected (string) "csp-violation" but got (object) null
- FAIL [expected NOTRUN] subtest: CSP check precedes COEP check - COEP header first assert_equals: expected (string) "csp-violation" but got (object) null
- FAIL [expected NOTRUN] subtest: COEP check precedes X-Frame-Options check assert_equals: expected (string) "coep" but got (object) null
OK [expected TIMEOUT] /html/browsers/origin/cross-origin-objects/cross-origin-objects.html (#28569)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
- PASS [expected FAIL] subtest: createHTMLDocument
- PASS [expected FAIL] subtest: <template>
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic test (formdata event) assert_equals: expected "basic=test\r\n" but got ""
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- FAIL [expected PASS] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document assert_equals: expected "/html/webappapis/scripting/events/resources/open-window.html" but got "blank"
TIMEOUT /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
- FAIL [expected TIMEOUT] subtest: Sanity check: this all works as expected with no promises involved assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/window-to-open.html" but got "about:blank"
- FAIL [expected TIMEOUT] subtest: Fulfillment handler on fulfilled promise assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/window-to-open.html" but got "about:blank"
- FAIL [expected TIMEOUT] subtest: Rejection handler on rejected promise assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/window-to-open.html" but got "about:blank"
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise Test timed out
- TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise Test timed out
TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript: Test timed out
ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)

Stable unexpected results (1)

TIMEOUT [expected PASS] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html

github-actions · 2023-08-02T13:46:17Z

⚠️ Try run (#5739125004) failed.

github-actions · 2023-08-02T14:27:34Z

Test results for linux-wpt-layout-2013 from try job (#5739487511):

Flaky unexpected result (11)

TIMEOUT [expected OK] /FileAPI/url/url-charset.window.html (#26997)
- TIMEOUT [expected PASS] subtest: Blob charset should override any auto-detected charset. Test timed out
- TIMEOUT [expected PASS] subtest: Blob charset should override <meta charset>. Test timed out
OK /_mozilla/mozilla/getBoundingClientRect.html (#18328)
- FAIL [expected PASS] subtest: getBoundingClientRect 1 assert_equals: expected 62 but got 60.35
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
- PASS [expected FAIL] subtest: createHTMLDocument
- PASS [expected FAIL] subtest: <template>
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
- TIMEOUT [expected PASS] subtest: Verifies that location navigations take precedence when following form submissions. Test timed out
ERROR /resource-timing/content-type-parsing.html (#29131)
- FAIL [expected TIMEOUT] subtest: mime-type 16 : text/html;charset=�gbk assert_equals: expected (string) "text/html" but got (undefined) undefined
- TIMEOUT [expected NOTRUN] subtest: mime-type 17 : text/html;charset=gbk Test timed out
TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out

Stable unexpected results that are known to be intermittent (11)

OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
- PASS [expected FAIL] subtest: Instant scrolling while doing history navigation.
- PASS [expected FAIL] subtest: Smooth scrolling while doing history navigation.
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- PASS [expected TIMEOUT] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
- FAIL [expected PASS] subtest: border-image sec-fetch-site - HTTPS downgrade (header not sent) assert_unreached: Reached unreachable code
OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/failure-check-sequence.https.html (#28207)
- FAIL [expected TIMEOUT] subtest: CSP check precedes X-Frame-Options check assert_equals: expected (string) "csp-violation" but got (object) null
- FAIL [expected NOTRUN] subtest: CSP check precedes COEP check - CSP header first assert_equals: expected (string) "csp-violation" but got (object) null
- FAIL [expected NOTRUN] subtest: CSP check precedes COEP check - COEP header first assert_equals: expected (string) "csp-violation" but got (object) null
- FAIL [expected NOTRUN] subtest: COEP check precedes X-Frame-Options check assert_equals: expected (string) "coep" but got (object) null
OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- FAIL [expected TIMEOUT] subtest: Navigating to a different document with form submission assert_equals: expected "http://web-platform.test:8000/common/blank.html?1=" but got "about:blank"
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='' assert_unreached: load should not be fired Reached unreachable code
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- FAIL [expected PASS] subtest: Check that rel=noopener with target=_self does a normal load this.openedWindow.findLink is not a function
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- FAIL [expected PASS] subtest: The end: DOMContentLoaded and defer scripts assert_false: DOMContentLoaded should not have fired before executing a task queued from a defer script expected false got true
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- FAIL [expected PASS] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document assert_equals: expected "/html/webappapis/scripting/events/resources/open-window.html" but got "blank"
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html (#25805)
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise Test timed out
- TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise Test timed out
TIMEOUT /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
- FAIL [expected TIMEOUT] subtest: Sanity check: this all works as expected with no promises involved assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/window-to-open.html" but got "about:blank"
- FAIL [expected TIMEOUT] subtest: Fulfillment handler on fulfilled promise assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/window-to-open.html" but got "about:blank"
- FAIL [expected TIMEOUT] subtest: Rejection handler on rejected promise assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/window-to-open.html" but got "about:blank"
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise Test timed out
- TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise Test timed out

github-actions · 2023-08-02T14:28:05Z

✨ Try run (#5739487511) succeeded.

mrobinson · 2023-08-02T16:56:03Z

CI failed because of #30063.

mrobinson · 2023-08-02T18:46:57Z

CI failed due to #30064.

dvtkrlbs force-pushed the bump-base64 branch from c554358 to 47bd465 Compare May 28, 2023 19:26

jdm reviewed May 28, 2023

View reviewed changes

Cargo.lock Outdated Show resolved Hide resolved

dvtkrlbs force-pushed the bump-base64 branch 2 times, most recently from 9031b58 to f34d56d Compare May 28, 2023 20:22

dvtkrlbs requested a review from jdm May 28, 2023 20:24

bump base64 from 0.10 to 0.21

06d8c75

mrobinson force-pushed the bump-base64 branch from a3d755b to db7c1c9 Compare August 2, 2023 12:58

mrobinson requested a review from mukilan August 2, 2023 12:59

Fix configuration of bitflags

42e818d

mrobinson force-pushed the bump-base64 branch from db7c1c9 to 42e818d Compare August 2, 2023 13:29

mrobinson approved these changes Aug 2, 2023

View reviewed changes

mrobinson added this pull request to the merge queue Aug 2, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2023

mrobinson added this pull request to the merge queue Aug 2, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2023

mrobinson added this pull request to the merge queue Aug 2, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2023

mrobinson added this pull request to the merge queue Aug 2, 2023

Merged via the queue into servo:master with commit 4c8db6a Aug 2, 2023
9 checks passed

EnnuiL mentioned this pull request Aug 11, 2023

Tackle half of canvas.toDataURL's FIXMEs #30094

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump base64 from 0.10 to 0.21 #29804

bump base64 from 0.10 to 0.21 #29804

dvtkrlbs commented May 28, 2023 •

edited by mrobinson

dvtkrlbs commented May 28, 2023

jdm commented May 28, 2023

bors-servo commented May 28, 2023

bors-servo commented May 28, 2023

jdm commented May 28, 2023

bors-servo commented May 28, 2023

bors-servo commented May 28, 2023

dvtkrlbs commented May 28, 2023

github-actions bot commented May 28, 2023

jdm commented May 28, 2023

dvtkrlbs commented May 28, 2023

dvtkrlbs commented May 28, 2023 •

edited

dvtkrlbs commented Jun 1, 2023

mrobinson commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

mrobinson commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

mrobinson commented Aug 2, 2023

mrobinson commented Aug 2, 2023

bump base64 from 0.10 to 0.21 #29804

bump base64 from 0.10 to 0.21 #29804

Conversation

dvtkrlbs commented May 28, 2023 • edited by mrobinson

dvtkrlbs commented May 28, 2023

jdm commented May 28, 2023

bors-servo commented May 28, 2023

bors-servo commented May 28, 2023

jdm commented May 28, 2023

bors-servo commented May 28, 2023

bors-servo commented May 28, 2023

dvtkrlbs commented May 28, 2023

github-actions bot commented May 28, 2023

jdm commented May 28, 2023

dvtkrlbs commented May 28, 2023

dvtkrlbs commented May 28, 2023 • edited

dvtkrlbs commented Jun 1, 2023

mrobinson commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

mrobinson commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

mrobinson commented Aug 2, 2023

mrobinson commented Aug 2, 2023

dvtkrlbs commented May 28, 2023 •

edited by mrobinson

dvtkrlbs commented May 28, 2023 •

edited