Use raw handles to create surfman contexts #29871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have published surfman 0.7.0 and surfman-chains 0.8.0. |
|
Thanks for updating it. I think webxr also need to update the dependencies. |
|
@bors-servo r+ |
|
📌 Commit b2bc037 has been approved by |
bors-servo
added a commit
that referenced
this pull request
Jun 16, 2023
Use raw handles to create surfman context instead <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it only changes how winit port create surfman contexts. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> It's amazing to see many activities on Servo recently. I would like to look into building it as a library crate again. But I think it's best I could start something small to prevent getting stuck. I hope it can accept any kind of window libraries and frameworks, with something like winit as fallback. There will be people using various tools like gtk, UI kit, glazier (window crate from druid community). Exposing API to accept raw window and display handle should do the work. And I think this can start with chaning internal use first. However, `Connection::from_raw_display_handle` isn't included in version 0.6, so I have to patch it. Could it release another version for this?
|
Test results for linux-wpt-layout-2020 from try job (#5294202453): Flaky unexpected result (2)
Stable unexpected results that are known to be intermittent (1)
|
|
Test results for linux-wpt-layout-2013 from try job (#5294202453): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (12)
|
|
💔 Test failed - checks-github |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jun 17, 2023
Use raw handles to create surfman context instead <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it only changes how winit port create surfman contexts. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> It's amazing to see many activities on Servo recently. I would like to look into building it as a library crate again. But I think it's best I could start something small to prevent getting stuck. I hope it can accept any kind of window libraries and frameworks, with something like winit as fallback. There will be people using various tools like gtk, UI kit, glazier (window crate from druid community). Exposing API to accept raw window and display handle should do the work. And I think this can start with chaning internal use first. However, `Connection::from_raw_display_handle` isn't included in version 0.6, so I have to patch it. Could it release another version for this?
|
Test results for linux-wpt-layout-2020 from try job (#5295987971): Stable unexpected results that are known to be intermittent (1)
|
|
Test results for linux-wpt-layout-2013 from try job (#5295987971): Flaky unexpected result (13)
Stable unexpected results that are known to be intermittent (12)
|
|
💔 Test failed - checks-github |
|
It looks like the |
|
Windows build failed and wait for servo/surfman#253. |
|
I've published surfman 0.7.1. You should be able to run |
|
@bors-servo r+ |
|
📌 Commit e7623bb has been approved by |
bors-servo
added a commit
that referenced
this pull request
Jun 20, 2023
Use raw handles to create surfman context instead <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it only changes how winit port create surfman contexts. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> It's amazing to see many activities on Servo recently. I would like to look into building it as a library crate again. But I think it's best I could start something small to prevent getting stuck. I hope it can accept any kind of window libraries and frameworks, with something like winit as fallback. There will be people using various tools like gtk, UI kit, glazier (window crate from druid community). Exposing API to accept raw window and display handle should do the work. And I think this can start with chaning internal use first. However, `Connection::from_raw_display_handle` isn't included in version 0.6, so I have to patch it. Could it release another version for this?
|
Test results for linux-wpt-layout-2013 from try job (#5324394329): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (11)
|
|
💔 Test failed - checks-github |
|
Interesting; the windows smoke test failed. |
|
Sorry I'm still triaging issues when I build servo on Windows. |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Jun 21, 2023
Use raw handles to create surfman context instead <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it only changes how winit port create surfman contexts. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> It's amazing to see many activities on Servo recently. I would like to look into building it as a library crate again. But I think it's best I could start something small to prevent getting stuck. I hope it can accept any kind of window libraries and frameworks, with something like winit as fallback. There will be people using various tools like gtk, UI kit, glazier (window crate from druid community). Exposing API to accept raw window and display handle should do the work. And I think this can start with chaning internal use first. However, `Connection::from_raw_display_handle` isn't included in version 0.6, so I have to patch it. Could it release another version for this?
|
Test results for linux-wpt-layout-2020 from try job (#5333791777): Flaky unexpected result (2)
|
|
Test results for linux-wpt-layout-2013 from try job (#5333791777): Flaky unexpected result (9)
Stable unexpected results that are known to be intermittent (17)
|
|
💔 Test failed - checks-github |
|
☔ The latest upstream changes (presumably #29961) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Rebased. @bors-servo try |
|
🔨 Triggering try run (#5729712656) with platform=all and layout=all |
|
Test results for linux-wpt-layout-2020 from try job (#5729712656): Flaky unexpected result (3)
|
|
Test results for linux-wpt-layout-2013 from try job (#5729712656): Flaky unexpected result (11)
Stable unexpected results that are known to be intermittent (10)
|
|
✨ Try run (#5729712656) succeeded. |
mrobinson
changed the title
mrobinson
approved these changes
Aug 2, 2023
|
I rebased this and pushed a few minor style fixes. I'll send it to the MQ. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This is failing the Windows smoketest: |
|
@mrobinson Sorry I forgot to update status of this PR, because I'm still busing moving house. |
|
@wusyong Thanks for the heads up. I've published a new version of surfman and updated this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsIt's amazing to see many activities on Servo recently. I would like to look into building it as a library crate again.
But I think it's best I could start something small to prevent getting stuck.
I hope it can accept any kind of window libraries and frameworks, with something like winit as fallback.
There will be people using various tools like gtk, UI kit, glazier (window crate from druid community).
Exposing API to accept raw window and display handle should do the work.
And I think this can start with chaning internal use first.
However,
Connection::from_raw_display_handleisn't included in version 0.6, so I have to patch it.Could it release another version for this?