Update mozangle, cc, and cmake #29947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to try this update again and see what we can do to get it landed. |
mrobinson
force-pushed
the
update-mozangle
branch
4 times, most recently
from
9603566
to
c2d2d01
Compare
mrobinson
force-pushed
the
update-mozangle
branch
5 times, most recently
from
b22b61c
to
804338e
Compare
jdm
approved these changes
Jun 29, 2023
|
@bors-servo r+ |
|
📌 Commit 804338e has been approved by |
bors-servo
added a commit
that referenced
this pull request
Jun 30, 2023
Update mozangle, cc, and cmake This also moves some environment variable configuration to the shared `build_env()` method, because previously clang was only being chosen for running `./mach build` and not `./mach test-unit` which was leading to rebuilds and thus build failures when running `test-unit`. I guess the cmake crate does not expect the compiler to change between subsequent runs. Fixes #29674 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they do not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Test results for linux-wpt-layout-2020 from try job (#5418742780): |
|
Test results for linux-wpt-layout-2013 from try job (#5418742780): Flaky unexpected result (11)
Stable unexpected results that are known to be intermittent (10)
|
|
💔 Test failed - checks-github |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jun 30, 2023
Update mozangle, cc, and cmake This also moves some environment variable configuration to the shared `build_env()` method, because previously clang was only being chosen for running `./mach build` and not `./mach test-unit` which was leading to rebuilds and thus build failures when running `test-unit`. I guess the cmake crate does not expect the compiler to change between subsequent runs. Fixes #29674 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they do not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Test results for linux-wpt-layout-2020 from try job (#5419201941): Flaky unexpected result (2) |
|
Test results for linux-wpt-layout-2013 from try job (#5419201941): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (13)
|
|
💔 Test failed - checks-github |
sagudev
reviewed
Jun 30, 2023
python/servo/command_base.py
Outdated
Comment on lines
592
to
596
| if "msvc" in servo.platform.host_triple(): | ||
| # on MSVC, we need some DLLs in the path. They were copied | ||
| # in to the servo.exe build dir, so just point PATH to that. | ||
| util.prepend_paths_to_env(env, "PATH", path.dirname(self.get_binary_path(False, False))) | ||
|
|
There was a problem hiding this comment.
This one is actually dirty hack for unit-tests, which I would like to remove so unit-tests could run independently of ./mach build. See #29815 (comment)
This also moves some environment variable configuration to the shared `build_env()` method, because previously clang was only being chosen for running `./mach build` and not `./mach test-unit` which was leading to rebuilds and thus build failures when running `test-unit`. I guess the cmake crate does not expect the compiler to change between subsequent runs.
mrobinson
force-pushed
the
update-mozangle
branch
from
804338e
to
ddc7994
Compare
|
@bors-servo r=jdm |
|
📌 Commit ddc7994 has been approved by |
|
Test results for linux-wpt-layout-2020 from try job (#5420556019): Flaky unexpected result (2)
|
|
Test results for linux-wpt-layout-2013 from try job (#5420556019): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (12)
|
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also moves some environment variable configuration to the shared
build_env()method, because previously clang was only being chosen forrunning
./mach buildand not./mach test-unitwhich was leading torebuilds and thus build failures when running
test-unit. I guess thecmake crate does not expect the compiler to change between subsequent
runs.
Fixes #29674
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors