-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
constellation: focusing and closing webviews #30842
Conversation
5036a3d
to
2e582d1
Compare
3f92d84
to
90f038b
Compare
🔨 Triggering try run (#7138381764) with platforms=linux and layout=2020 |
Test results for linux-wpt-layout-2020 from try job (#7138381764): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (17)
Stable unexpected results (1)
|
|
90f038b
to
d3ce4a7
Compare
🔨 Triggering try run (#7405933481) with platforms=linux,macos,windows and layout=undefined |
Test results for linux-wpt-layout-2020 from try job (#7405933481): Flaky unexpected result (12)
Stable unexpected results that are known to be intermittent (19)
|
Test results for linux-wpt-layout-2013 from try job (#7405933481): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (16)
|
|
✨ Try run (#7405933481) succeeded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. I have some comments, some of them quite trivial, but I think the most important conversation is the one about whether the Constellation should have a concept of a window.
🔨 Triggering try run (#7635496423) with platforms=linux and layout=2020 |
Test results for linux-wpt-layout-2020 from try job (#7635496423): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (15)
|
✨ Try run (#7635496423) succeeded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a couple comments below, but otherwise this looks good.
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* constellation: focusing, closing, and native window visibility * rename “browser” to “webview”, “unfocus” to “blur” * remove native window visibility from constellation * rename more “browser” to “webview” * guard clauses * don’t automatically focus when no webviews are focused * comment spec steps for window.close() * use format interpolation Co-authored-by: Martin Robinson <mrobinson@igalia.com> * fix formatting * rename “Webview” to “WebView” in types and type parameters --------- Co-authored-by: Martin Robinson <mrobinson@igalia.com>
This patch improves support in the constellation for multiple top-level browsing contexts aka “webviews”, or in some older code, “browsers”.
We also fix two existing bugs in the logic for closing webviews: one where browsing context groups always leak, and one where browsing context groups get removed even when non-empty.
constellation
servoshell
messages
embedder →* constellation
embedder ← constellation
./mach build -d
does not report any errors./mach test-tidy
does not report any errors