constellation: focusing and closing webviews #30842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delan
force-pushed
the
constellation-browser-manager
branch
from
5036a3d
to
2e582d1
Compare
40 tasks
delan
changed the title
delan
changed the title
delan
force-pushed
the
constellation-browser-manager
branch
2 times, most recently
from
3f92d84
to
90f038b
Compare
|
🔨 Triggering try run (#7138381764) with platforms=linux and layout=2020 |
|
Test results for linux-wpt-layout-2020 from try job (#7138381764): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (17)
Stable unexpected results (1)
|
|
|
delan
force-pushed
the
constellation-browser-manager
branch
from
90f038b
to
d3ce4a7
Compare
|
🔨 Triggering try run (#7405933481) with platforms=linux,macos,windows and layout=undefined |
|
Test results for linux-wpt-layout-2020 from try job (#7405933481): Flaky unexpected result (12)
Stable unexpected results that are known to be intermittent (19)
|
|
Test results for linux-wpt-layout-2013 from try job (#7405933481): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (16)
|
|
|
|
✨ Try run (#7405933481) succeeded. |
mrobinson
reviewed
Jan 13, 2024
|
🔨 Triggering try run (#7635496423) with platforms=linux and layout=2020 |
|
Test results for linux-wpt-layout-2020 from try job (#7635496423): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (15)
|
|
✨ Try run (#7635496423) succeeded. |
mrobinson
approved these changes
Jan 24, 2024
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
* constellation: focusing, closing, and native window visibility * rename “browser” to “webview”, “unfocus” to “blur” * remove native window visibility from constellation * rename more “browser” to “webview” * guard clauses * don’t automatically focus when no webviews are focused * comment spec steps for window.close() * use format interpolation Co-authored-by: Martin Robinson <mrobinson@igalia.com> * fix formatting * rename “Webview” to “WebView” in types and type parameters --------- Co-authored-by: Martin Robinson <mrobinson@igalia.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Mar 6, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves support in the constellation for multiple top-level browsing contexts aka “webviews”, or in some older code, “browsers”.
We also fix two existing bugs in the logic for closing webviews: one where browsing context groups always leak, and one where browsing context groups get removed even when non-empty.
constellation
servoshell
messages
embedder →* constellation
embedder ← constellation
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors