Fix a crash in WebGPU when WebGPU is disabled #30888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Fabián Montenegro <40044087+lucasMontenegro@users.noreply.github.com>
gterzian
requested changes
Dec 19, 2023
mrobinson
changed the title
gterzian
approved these changes
Dec 20, 2023
| return warn!("Failed to send request adapter message on WebGPU channel"); | ||
| } | ||
| FromScriptMsg::RequestAdapter(response_sender, options, ids) => match webgpu_chan { | ||
| None => warn!("Failed to send request adapter message, missing WebGPU channel"), |
|
Thank you @gterzian 🥳🎉 |
|
@lucasMontenegro You're welcome. We have a zullip chat by the way, in case you have any question: https://servo.zulipchat.com/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors