-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPU: fail request for adapter when not available. #30895
Comments
@gterzian @lucasMontenegro can I pick this one? |
Hello @gterzian and @Taym95. I'm sorry I somehow missed this thread. Thanks to your comment it finally came to my attention @Taym95 . I'm unable to contribute now since I just installed a new OS that I'm unfamiliar with. Maybe tomorrow I'll be ready to contribute again. I'm okay with someone else taking over, of course. |
Ok, there is no rush. @lucasMontenegro please let us know if you prefer that @Taym95 takes it... |
Yeah, I'm okay with it |
cc @Taym95 |
@servo-highfive: assign me |
Hey @Taym95! Thanks for your interest in working on this issue. It's now assigned to you! |
@Taym95 Did you have a chance to look at it? |
Yes, I am working on it and have some questions. I am seeking responses from the team before submitting the pull request |
Depends on #30888
See the changes at https://github.com/servo/servo/pull/30888/files/4bec9ef169f51c91f616b854e231484bbd983366#diff-95aa2eb890fe794918afdadfb6a89e026ec80222ceb8e5a21768d528e9ce036cR2066
This will simply leave the async handler in script waiting forever, instead we should send a message back and properly handle the case where WebGPU is not available(re "properly", look at the spec .
See
servo/components/script/dom/gpu.rs
Line 108 in 8bbcf0a
The text was updated successfully, but these errors were encountered: