Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPU: fail request for adapter when not available. #30895

Closed
gterzian opened this issue Dec 20, 2023 · 10 comments · Fixed by #31002
Closed

WebGPU: fail request for adapter when not available. #30895

gterzian opened this issue Dec 20, 2023 · 10 comments · Fixed by #31002
Labels
A-constellation Involves the constellation A-content/script Related to the script thread A-content/webgpu The WebGPU implementation. C-assigned There is someone working on resolving the issue E-more-complex Variable effort required; may require a mentor. Recommended solution is clearly described in the iss

Comments

@gterzian
Copy link
Member

Depends on #30888

See the changes at https://github.com/servo/servo/pull/30888/files/4bec9ef169f51c91f616b854e231484bbd983366#diff-95aa2eb890fe794918afdadfb6a89e026ec80222ceb8e5a21768d528e9ce036cR2066

This will simply leave the async handler in script waiting forever, instead we should send a message back and properly handle the case where WebGPU is not available(re "properly", look at the spec .

See

let sender = response_async(&promise, self);

@gterzian gterzian added A-content/script Related to the script thread A-constellation Involves the constellation A-content/webgpu The WebGPU implementation. labels Dec 20, 2023
@gterzian
Copy link
Member Author

cc @lucasMontenegro

@gterzian gterzian added the E-more-complex Variable effort required; may require a mentor. Recommended solution is clearly described in the iss label Dec 21, 2023
@Taym95
Copy link
Contributor

Taym95 commented Dec 26, 2023

@gterzian @lucasMontenegro can I pick this one?

@lucasMontenegro
Copy link
Contributor

Hello @gterzian and @Taym95. I'm sorry I somehow missed this thread. Thanks to your comment it finally came to my attention @Taym95 .

I'm unable to contribute now since I just installed a new OS that I'm unfamiliar with. Maybe tomorrow I'll be ready to contribute again. I'm okay with someone else taking over, of course.

@gterzian
Copy link
Member Author

Ok, there is no rush. @lucasMontenegro please let us know if you prefer that @Taym95 takes it...

@lucasMontenegro
Copy link
Contributor

Yeah, I'm okay with it

@gterzian
Copy link
Member Author

cc @Taym95

@Taym95
Copy link
Contributor

Taym95 commented Dec 29, 2023

@servo-highfive: assign me

@servo-highfive servo-highfive added the C-assigned There is someone working on resolving the issue label Dec 29, 2023
@servo-highfive
Copy link

Hey @Taym95! Thanks for your interest in working on this issue. It's now assigned to you!

@beaufortfrancois
Copy link

@Taym95 Did you have a chance to look at it?

@Taym95
Copy link
Contributor

Taym95 commented Jan 3, 2024

@Taym95 Did you have a chance to look at it?

Yes, I am working on it and have some questions. I am seeking responses from the team before submitting the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-constellation Involves the constellation A-content/script Related to the script thread A-content/webgpu The WebGPU implementation. C-assigned There is someone working on resolving the issue E-more-complex Variable effort required; may require a mentor. Recommended solution is clearly described in the iss
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants