WebGPU: always send exit message to script before exiting #30989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gterzian
changed the title
sagudev
reviewed
Jan 3, 2024
There was a problem hiding this comment.
LGTM, but I would like to wait for webgpu run: https://github.com/sagudev/servo/actions/runs/7398389520
|
New run for updated expectations: https://github.com/sagudev/servo/actions/runs/7398819825 |
sagudev
force-pushed
the
fix_webgpu_error_handling
branch
from
190e457
to
246d556
Compare
|
Thanks for the review and test update! @sagudev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When WebGPU exits, including when it internally encounters an error, always first send the
Exitmessage to script before exiting../mach build -ddoes not report any errors./mach test-tidydoes not report any errors