-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webgpureport.org crashes servo #30915
Comments
Removing Crash line is: servo/components/script/script_thread.rs Line 1498 in 1f0f50b
|
Actually this site works for me on both linux and windows. @beaufortfrancois you are using mac, right? |
I'm using macOS. I wonder if it crashes if the system doesn't have a fallback adapter, which is the case on my macBook machine. |
But forcing fallback adapter helps? Could you try |
It's actually removing
|
|
Does website works on firefox on your machine? |
Try setting RUST_LOG=trace and paste the output from servo terminal invocation (ex: |
|
Here are more logs:
|
I can also reproduce the same error with the javascript code below: const adapter = await navigator.gpu.requestAdapter();
const device = await adapter.requestDevice({
requiredLimits: { maxTextureDimension1D: 123456 },
}); You can try it at https://red-triangle-webgpu.glitch.me/servo-issue-30915.html |
Thanks, I can reproduce this on my computer. It's not exactly the same error but goes through same path (that we apparently handle badly). script::dom::gpuadapter Could not get GPUDevice causes panic |
Properly handling this is part of #30895 (this issue is then more about "why is there no adapter returned on a Mac?") |
Actually this was another problem, pr opened... |
The crash is fixed by #30989 Note that the actual error happened here, and it returned [wgpu_core::instance::RequestAdapterError. ](https://docs.rs/wgpu-core/latest/wgpu_core/instance/enum.RequestAdapterError.html#variant.NotFound). Why no adapter is found on a Mac M2 is perhaps an issue to file directly at https://github.com/gfx-rs/wgpu ? |
I think not because, wgpu-info does found it. We probably need to re-review our backends choices or get for equivalent of |
Discussed in #30914
Originally posted by beaufortfrancois December 22, 2023
When running Servo 0.0.1-5e8f70f with
--pref dom.webgpu.enabled
, it fails to render https://webgpureport.org/Without the pref, it loads and simply says WebGPU is not supported.
Is this a known issue?
The text was updated successfully, but these errors were encountered: