Fix failed request for adapter when not available #31002

Taym95 · 2024-01-04T15:11:13Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix WebGPU: fail request for adapter when not available. #30895

These changes do not require tests because ___

gterzian

Thanks for your contribution!

The messaging is actually quite complicated, and it's only the initial RequestAdapter that can return None if webgpu is unavailable, but because of the way the ipc sender is passed through to webgpu, all others still need to return an option...

components/script/dom/gpu.rs

components/webgpu/lib.rs

components/script/dom/gpuadapter.rs

components/script/dom/gpubuffer.rs

components/script/dom/gpuadapter.rs

components/constellation/constellation.rs

gterzian

LGTM, with one nit.

I think we may have to also update tests expectations, I assume some TIMEOUT will change to FAIL or PASS. @sagudev other than pointing to https://github.com/servo/servo/blob/main/tests/wpt/README.md#updating-test-expectations, are there other instructions on how to do it? I forgot how :)

components/script/dom/gpu.rs

components/script/dom/gpuadapter.rs

components/script/dom/gpubuffer.rs

github-actions · 2024-01-08T09:03:12Z

🔨 Triggering try run (#7445239236) with platforms=linux and layout=undefined

sagudev · 2024-01-08T09:45:07Z

try run: https://github.com/sagudev/servo/actions/runs/7445674351

github-actions · 2024-01-08T09:52:33Z

Test results for linux-wpt-layout-2020 from try job (#7445239236):

Flaky unexpected result (11)

FAIL [expected PASS] /_mozilla/mozilla/iframe/resize_after_load.html (#13573)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected FAIL] /css/css-animations/animation-delay-010.html (#26573)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank' assert_unreached: load should not be fired Reached unreachable code
TIMEOUT [expected CRASH] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped Test timed out
- NOTRUN [expected FAIL] subtest: Area element should support autofocus
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
- FAIL [expected PASS] subtest: DOMParser assert_unreached: got unexpected load event Reached unreachable code
- FAIL [expected PASS] subtest: createHTMLDocument assert_unreached: got unexpected error event Reached unreachable code
- FAIL [expected PASS] subtest: <template> assert_unreached: got unexpected error event Reached unreachable code
OK /html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html (#29137)
- PASS [expected FAIL] subtest: document.write in an imported module

Stable unexpected results that are known to be intermittent (21)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-weight: '400' should prefer '350 399' over '351 398'
- PASS [expected FAIL] subtest: Matching font-weight: '400' should prefer '351 398' over '501 550'
- PASS [expected FAIL] subtest: Matching font-weight: '430' should prefer '450 460' over '500'
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '350 399' over '340 398' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-weight: '500' should prefer '501 550' over '502 560'
- FAIL [expected PASS] subtest: Matching font-stretch: '90%' should prefer '60% 70%' over '110% 140%' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'normal' over 'oblique 0deg' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 20deg' should prefer 'oblique 40deg 50deg' over 'oblique 10deg' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 20deg' should prefer 'oblique 0deg' over 'oblique -50deg -20deg'
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 40deg 50deg' over 'oblique 20deg' assert_equals: Unexpected font on test element expected 487 but got 532
- And 3 more unexpected results...
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- FAIL [expected PASS] subtest: listeners are called correct number of times assert_equals: expected 6 but got 5
TIMEOUT /dom/events/webkit-transition-end-event.html (#26497)
- FAIL [expected TIMEOUT] subtest: webkitTransitionEnd event listener should trigger for an animation assert_true: received webkitTransitionEnd event expected true got false
- TIMEOUT [expected NOTRUN] subtest: webkitTransitionEnd event listener should not trigger if an unprefixed listener also exists Test timed out
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- PASS [expected TIMEOUT] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- FAIL [expected PASS] subtest: sec-fetch-site - Not sent to non-trustworthy same-origin destination, no attributes promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-referrer.window.html (#29081)
- TIMEOUT [expected PASS] subtest: no-referrer referrer policy used to create the starting page Test timed out
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation lengths differ, expected array [6, 3] length 2, got [6, 2, 2] length 3
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- PASS [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
TIMEOUT /resource-timing/nested-context-navigations-iframe.html (#24311)
- PASS [expected TIMEOUT] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
- PASS [expected NOTRUN] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
- PASS [expected NOTRUN] subtest: Test that iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that crossorigin iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that cross-site iframe navigations are not observable by the parent
- TIMEOUT [expected NOTRUN] subtest: Test that iframe refreshes are not observable by the parent Test timed out
TIMEOUT [expected OK] /webaudio/the-audio-api/the-analysernode-interface/test-analysernode.html (#31014)
OK /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html (#22849)
- FAIL [expected PASS] subtest: X Stitched sine-wave buffers at sample rate 43800 does not equal [0,0.06264832615852356,0.12505052983760834,0.18696144223213196,0.24813786149024963,0.308339387178421,0.36732959747314453,0.4248766601085663,0.480754554271698,0.5347436666488647,0.5866320133209229,0.6362156271934509,0.6832997798919678,0.7276994585990906,0.7692402601242065,0.8077589869499207...] with an element-wise tolerance of {"absoluteThreshold":0.0038986,"relativeThreshold":0}.
  Index Actual Expected AbsError RelError Test threshold
  [15073] -1.6549071305923700e+24 6.4605611562728882e-1 1.6549071305923700e+24 2.5615532313095377e+24 3.8985999999999999e-3
  [15074] 2.5936898589134216e-1 5.9696805477142334e-1 3.3759906888008118e-1 5.6552283858697683e-1 3.8985999999999999e-3
  Max AbsError of 1.6549071305923700e+24 at index of 15073.
  Max RelError of 2.5615532313095377e+24 at index of 15073.
  assert_true: expected true got false
- FAIL [expected PASS] subtest: X SNR (-440.94138660063265 dB) is not greater than or equal to 65.737. Got -440.94138660063265. assert_true: expected true got false
TIMEOUT [expected CRASH] /webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html (#21408)
TIMEOUT [expected OK] /webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-audioparam.html (#31014)
TIMEOUT [expected OK] /webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse.html (#31014)
TIMEOUT [expected OK] /webaudio/the-audio-api/the-biquadfilternode-interface/biquadfilternode-basic.html (#31014)
OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
OK [expected ERROR] /workers/baseurl/alpha/import-in-moduleworker.html (#21315)
ERROR [expected OK] /workers/semantics/run-a-worker/003.html (#22765)

Stable unexpected results (1)

TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/about-srcdoc-navigation-blocked.window.html

github-actions · 2024-01-08T09:53:09Z

⚠️ Try run (#7445239236) failed.

sagudev · 2024-01-08T09:54:30Z

TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/about-srcdoc-navigation-blocked.window.html

Is very flaky lately, but it's unrelated to this PR.

sagudev

There is a lot of CRASH [expected OK] with Failed to get a response for BufferMapAsync (thread Script(1,1), at components/script/dom/gpubuffer.rs:369)

sagudev · 2024-01-08T10:19:32Z

You can reporoduce on local with:
./mach build --production
./mach test-wpt --production _webgpu/webgpu/cts.https.html?q=webgpu:api,operation,memory_sync,texture,same_subresource:ww:*

gterzian · 2024-01-08T13:28:01Z

There is a lot of CRASH [expected OK] with Failed to get a response for BufferMapAsync (thread Script(1,1), at components/script/dom/gpubuffer.rs:369)

I think there you need to send the option:

servo/components/webgpu/lib.rs

Line 445 in 2d859ac

if let Err(e) = info.sender.send(msg) {

It compiles only because of the casting here

servo/components/webgpu/lib.rs

Line 426 in 2d859ac

userdata as *const BufferMapInfo<WebGPUResponseResult>,

which should be changed to BufferMapInfo<Option<WebGPUResponseResult>>.

Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>

github-actions · 2024-01-09T06:01:40Z

🔨 Triggering try run (#7457261358) with platforms=linux and layout=undefined

sagudev · 2024-01-09T06:15:19Z

new try run for webgpu: https://github.com/sagudev/servo/actions/runs/7457368386

github-actions · 2024-01-09T06:49:17Z

Test results for linux-wpt-layout-2020 from try job (#7457261358):

Flaky unexpected result (16)

FAIL [expected PASS] /_mozilla/css/iframe/frameborder_a.html (#17407)
OK /_mozilla/css/stylesheet_media_queries.html (#17159)
- FAIL [expected PASS] subtest: Media queries within stylesheets assert_equals: expected "rgb(0, 255, 0)" but got "rgb(255, 0, 0)"
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected FAIL] /css/css-animations/animation-delay-010.html (#26573)
OK /css/cssom-view/MediaQueryListEvent.html (#25275)
- FAIL [expected PASS] subtest: argument of onchange assert_true: expected true got false
OK /dom/events/Event-dispatch-single-activation-behavior.html
- PASS [expected FAIL] subtest: When clicking child <A></A> of parent <INPUT type=checkbox></INPUT>, only child should be activated.
- PASS [expected FAIL] subtest: When clicking child <A></A> of parent <INPUT type=radio></INPUT>, only child should be activated.
- PASS [expected FAIL] subtest: When clicking child <A></A> of parent <FORM><INPUT type=submit></INPUT></FORM>, only child should be activated.
- PASS [expected FAIL] subtest: When clicking child <A></A> of parent <FORM><INPUT type=image></INPUT></FORM>, only child should be activated.
- PASS [expected FAIL] subtest: When clicking child <A></A> of parent <FORM><INPUT type=reset></INPUT></FORM>, only child should be activated.
- PASS [expected FAIL] subtest: When clicking child <A></A> of parent <FORM><BUTTON type=submit></BUTTON></FORM>, only child should be activated.
- PASS [expected FAIL] subtest: When clicking child <A></A> of parent <FORM><BUTTON type=reset></BUTTON></FORM>, only child should be activated.
- PASS [expected FAIL] subtest: When clicking child <A></A> of parent <AREA></AREA>, only child should be activated.
- PASS [expected FAIL] subtest: When clicking child <A></A> of parent <DETAILS><SUMMARY></SUMMARY></DETAILS>, only child should be activated.
- PASS [expected FAIL] subtest: When clicking child <A></A> of parent <LABEL><INPUT type=checkbox></INPUT><SPAN></SPAN></LABEL>, only child should be activated.
- And 1 more unexpected results...
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- PASS [expected FAIL] subtest: Navigating to a different document with form submission
TIMEOUT [expected OK] /html/browsers/origin/cross-origin-objects/cross-origin-objects.html (#28569)
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
ERROR [expected OK] /html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-url.html
TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
OK [expected ERROR] /workers/baseurl/alpha/import-in-moduleworker.html (#21315)
ERROR [expected OK] /workers/baseurl/alpha/sharedworker-in-worker.html (#21315)

Stable unexpected results that are known to be intermittent (14)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '420 440' over '450 460' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '350 399' over '340 398' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-weight: '500' should prefer '450 460' over '400'
- PASS [expected FAIL] subtest: Matching font-weight: '500' should prefer '351 398' over '501 550'
- PASS [expected FAIL] subtest: Matching font-weight: '501' should prefer '501' over '502 510'
- PASS [expected FAIL] subtest: Matching font-weight: '501' should prefer '503 520' over '500'
- PASS [expected FAIL] subtest: Matching font-weight: '501' should prefer '500' over '450 460'
- PASS [expected FAIL] subtest: Matching font-stretch: '110%' should prefer '105%' over '100%'
- FAIL [expected PASS] subtest: Matching font-stretch: '90%' should prefer '60% 70%' over '110% 140%' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'normal' over 'oblique 0deg' assert_equals: Unexpected font on test element expected 487 but got 532
- And 7 more unexpected results...
OK [expected TIMEOUT] /dom/events/webkit-transition-end-event.html (#26497)
- FAIL [expected TIMEOUT] subtest: webkitTransitionEnd event listener should trigger for an animation assert_true: received webkitTransitionEnd event expected true got false
- PASS [expected NOTRUN] subtest: webkitTransitionEnd event listener should not trigger if an unprefixed listener also exists
- PASS [expected NOTRUN] subtest: webkitTransitionEnd event listener should not trigger if an unprefixed event handler also exists
- FAIL [expected NOTRUN] subtest: event types for prefixed and unprefixed transitionend event listeners should be named appropriately assert_equals: expected (string) "webkitTransitionEnd" but got (undefined) undefined
- PASS [expected NOTRUN] subtest: webkitTransitionEnd event listener is case sensitive
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- PASS [expected TIMEOUT] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- FAIL [expected PASS] subtest: sec-fetch-site - Not sent to non-trustworthy same-origin destination, no attributes promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
- FAIL [expected TIMEOUT] subtest: sec-fetch-site - Not sent to non-trustworthy same-site destination, no attributes promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
- TIMEOUT [expected NOTRUN] subtest: sec-fetch-site - Not sent to non-trustworthy cross-site destination, no attributes Test timed out
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-referrer.window.html (#29081)
- TIMEOUT [expected PASS] subtest: no-referrer referrer policy used to create the starting page Test timed out
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
OK /html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html (#29137)
- PASS [expected FAIL] subtest: document.write in an imported module
ERROR /resource-timing/content-type-parsing.html (#29131)
- FAIL [expected TIMEOUT] subtest: mime-type 16 : text/html;charset=�gbk assert_equals: expected (string) "text/html" but got (undefined) undefined
- TIMEOUT [expected NOTRUN] subtest: mime-type 17 : text/html;charset=gbk Test timed out
TIMEOUT /resource-timing/nested-context-navigations-iframe.html (#24311)
- PASS [expected TIMEOUT] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
- PASS [expected NOTRUN] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
- PASS [expected NOTRUN] subtest: Test that iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that crossorigin iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that cross-site iframe navigations are not observable by the parent
- TIMEOUT [expected NOTRUN] subtest: Test that iframe refreshes are not observable by the parent Test timed out
OK /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html (#22849)
- FAIL [expected PASS] subtest: X Stitched sine-wave buffers at sample rate 43800 does not equal [0,0.06264832615852356,0.12505052983760834,0.18696144223213196,0.24813786149024963,0.308339387178421,0.36732959747314453,0.4248766601085663,0.480754554271698,0.5347436666488647,0.5866320133209229,0.6362156271934509,0.6832997798919678,0.7276994585990906,0.7692402601242065,0.8077589869499207...] with an element-wise tolerance of {"absoluteThreshold":0.0038986,"relativeThreshold":0}.
  Index Actual Expected AbsError RelError Test threshold
  [15073] 6.7627876837199630e-32 6.4605611562728882e-1 6.4605611562728882e-1 1.0000000000000000e+0 3.8985999999999999e-3
  [15074] 2.5936898589134216e-1 5.9696805477142334e-1 3.3759906888008118e-1 5.6552283858697683e-1 3.8985999999999999e-3
  Max AbsError of 6.4605611562728882e-1 at index of 15073.
  Max RelError of 1.0000000000000000e+0 at index of 15073.
  assert_true: expected true got false
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:

github-actions · 2024-01-09T06:49:47Z

✨ Try run (#7457261358) succeeded.

gterzian

LGTM. @sagudev I think we're good on the tests, right?

sagudev

Webgpu try run looks good.

gterzian requested changes Jan 5, 2024

View reviewed changes

Taym95 force-pushed the fix-failed-request-for-adapter-when-not-available branch from b8ca785 to 6554e8e Compare January 5, 2024 09:19

sagudev reviewed Jan 5, 2024

View reviewed changes

components/constellation/constellation.rs Show resolved Hide resolved

gterzian requested changes Jan 8, 2024

View reviewed changes

components/script/dom/gpu.rs Outdated Show resolved Hide resolved

components/script/dom/gpuadapter.rs Outdated Show resolved Hide resolved

components/script/dom/gpubuffer.rs Outdated Show resolved Hide resolved

Taym95 force-pushed the fix-failed-request-for-adapter-when-not-available branch from 6554e8e to 2d859ac Compare January 8, 2024 08:28

gterzian added the T-linux-wpt-2020 Do a try run of the WPT label Jan 8, 2024

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Jan 8, 2024

sagudev requested changes Jan 8, 2024

View reviewed changes

Fix failed request for adapter when not available

0dc2fff

Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>

Taym95 force-pushed the fix-failed-request-for-adapter-when-not-available branch from 2d859ac to 0dc2fff Compare January 8, 2024 15:05

gterzian added the T-linux-wpt-2020 Do a try run of the WPT label Jan 9, 2024

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Jan 9, 2024

gterzian approved these changes Jan 9, 2024

View reviewed changes

sagudev approved these changes Jan 9, 2024

View reviewed changes

mrobinson added this pull request to the merge queue Jan 9, 2024

Merged via the queue into servo:main with commit fddc4a4 Jan 9, 2024
41 checks passed

sagudev mentioned this pull request Jul 12, 2024

Less nesting on WebGPUResponse #32766

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix failed request for adapter when not available #31002

Fix failed request for adapter when not available #31002

Taym95 commented Jan 4, 2024 •

edited

Loading

gterzian left a comment •

edited

Loading

gterzian left a comment

github-actions bot commented Jan 8, 2024

sagudev commented Jan 8, 2024

github-actions bot commented Jan 8, 2024

github-actions bot commented Jan 8, 2024

sagudev commented Jan 8, 2024

sagudev left a comment

sagudev commented Jan 8, 2024

gterzian commented Jan 8, 2024 •

edited

Loading

github-actions bot commented Jan 9, 2024

sagudev commented Jan 9, 2024

github-actions bot commented Jan 9, 2024

github-actions bot commented Jan 9, 2024

gterzian left a comment

sagudev left a comment

Fix failed request for adapter when not available #31002

Fix failed request for adapter when not available #31002

Conversation

Taym95 commented Jan 4, 2024 • edited Loading

gterzian left a comment • edited Loading

Choose a reason for hiding this comment

gterzian left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 8, 2024

sagudev commented Jan 8, 2024

github-actions bot commented Jan 8, 2024

github-actions bot commented Jan 8, 2024

sagudev commented Jan 8, 2024

sagudev left a comment

Choose a reason for hiding this comment

sagudev commented Jan 8, 2024

gterzian commented Jan 8, 2024 • edited Loading

github-actions bot commented Jan 9, 2024

sagudev commented Jan 9, 2024

github-actions bot commented Jan 9, 2024

github-actions bot commented Jan 9, 2024

gterzian left a comment

Choose a reason for hiding this comment

sagudev left a comment

Choose a reason for hiding this comment

Taym95 commented Jan 4, 2024 •

edited

Loading

gterzian left a comment •

edited

Loading

gterzian commented Jan 8, 2024 •

edited

Loading