Convert etc/profilicate.py to Python 3 #31259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
approved these changes
Feb 5, 2024
mukilan
reviewed
Feb 5, 2024
| tid = 0 | ||
| threads = [] | ||
| for (name, raw_samples) in sorted(thread_data.iteritems(), key=lambda x: thread_order[x[0]]): | ||
| for (name, raw_samples) in sorted(iter(thread_data.items()), key=lambda x: thread_order[x[0]]): |
Member
There was a problem hiding this comment.
I think the iter() is is not needed in this case, since sorted can consume iterables directly and items() returns view objects that are iterable.
mukilan
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts
etc/profilicate.py(a script for processing raw profiler samples) from Python 2 to Python 3, to make it easier to run on modern systems. I used2to3, then removed unnecessary double brackets and updated the shebang../mach build -ddoes not report any errors./mach test-tidydoes not report any errors