Use thread pool to decode image #31517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
added
T-linux-wpt-2013
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#8170481055) for Linux WPT |
|
Test results for linux-wpt-layout-2013 from try job (#8170481055): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (13)
|
|
Test results for linux-wpt-layout-2020 from try job (#8170481055): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (14)
|
|
✨ Try run (#8170481055) succeeded. |
Taym95
reviewed
Mar 6, 2024
Co-authored-by: Taym Haddadi <haddadi.taym@gmail.com>
jdm
approved these changes
Mar 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mrobinson
reviewed
Mar 7, 2024
| @@ -431,6 +436,7 @@ impl ImageCache for ImageCacheImpl { | |||
| placeholder_url: ServoUrl::parse("chrome://resources/rippy.png").unwrap(), | |||
| webrender_api: webrender_api, | |||
| })), | |||
| thread_pool: CoreResourceThreadPool::new(16), | |||
There was a problem hiding this comment.
Why was 16 chosen here? This seems like too many threads for CPUs with fewer cores. Perhaps this can be limited to the number of cpus.
There was a problem hiding this comment.
It put it like that since it was the same as in components/net/resource_thread.rs, but here it probably makes more sense to limit it since it is a secondary thread pool. Should I set it to the number of cores then?
There was a problem hiding this comment.
Yes, perhaps the number of CPUs is a better number. Resource loading is network bound, while decoding is CPU bound.
There was a problem hiding this comment.
#31585 should address this changes
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion on #31504, changes image decoding in
components/net/image_cache.rsfrom creating a new thread into aCoreResourceThreadPool(different from the one created incomponents/net/resource_thread.rs).I would appreciate if someone could add the testing labels to check that automated tests keep working well, thanks!
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors