Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move convert_* functions into gpuconvert.rs #31521

Merged
merged 2 commits into from Mar 6, 2024
Merged

Conversation

eerii
Copy link
Contributor

@eerii eerii commented Mar 6, 2024

Centralizes all conversion functions between wgpu/webgpu bindings in one module, components/script/dom/gpuconvert.rs.


@sagudev sagudev changed the title Unify convert_* functions across gpu*.rs files Move convert_* functions into gpuconvert.rs Mar 6, 2024
Copy link
Member

@sagudev sagudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks for all the work.

This is only part of the issue (to put all convert files into one place), but I still haven't designed mechanism (macro+traits) for two way conversion.

@sagudev sagudev added this pull request to the merge queue Mar 6, 2024
@eerii
Copy link
Contributor Author

eerii commented Mar 6, 2024

Oh that makes a ton of sense, two way conversion would be way nicer! Thanks for reviewing and changing the description to match :D

Merged via the queue into servo:main with commit a817096 Mar 6, 2024
11 checks passed
@eerii eerii deleted the wgpu_convert branch March 6, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create convert mechanisem for WGPU <=> webgpu
2 participants