Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: fix warnings in components/shared #31565

Merged
merged 3 commits into from Mar 8, 2024
Merged

clippy: fix warnings in components/shared #31565

merged 3 commits into from Mar 8, 2024

Conversation

eerii
Copy link
Contributor

@eerii eerii commented Mar 7, 2024

Split from #31514, fixes some clippy warnings in components/shared.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes are part of Fix as many clippy problems as possible #31500
  • These changes do not require tests because they do not modify functionality, they only fix lint errors.

mrobinson
mrobinson requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just a couple small comments below:

components/shared/msg/constellation_msg.rs Outdated Show resolved Hide resolved
components/shared/msg/constellation_msg.rs Outdated Show resolved Hide resolved
components/shared/msg/constellation_msg.rs Outdated Show resolved Hide resolved
@mrobinson
Copy link
Member

This needs a rebase, but otherwise looks great. Thanks!

@mrobinson mrobinson added the S-needs-rebase There are merge conflict errors. label Mar 8, 2024
@eerii
Copy link
Contributor Author

eerii commented Mar 8, 2024

Thanks for the review! It should be rebased to main now

@jdm jdm enabled auto-merge March 8, 2024 14:41
@jdm jdm added this pull request to the merge queue Mar 8, 2024
Merged via the queue into servo:main with commit 43f4496 Mar 8, 2024
9 checks passed
@eerii eerii deleted the clippy_shared branch March 9, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
S-needs-rebase There are merge conflict errors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eerii @mrobinson @jdm