Fix rustdoc warnings in components/layout_2020
#31587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandeep Pillai <sandeeppillai@Sandeeps-MacBook-Air.local>
mrobinson
requested changes
Mar 8, 2024
components/layout_2020/flow/mod.rs
Outdated
| @@ -1372,7 +1372,7 @@ fn solve_block_margins_for_in_flow_block_level(pbm: &PaddingBorderMargin) -> (Le | |||
| } | |||
|
|
|||
| /// This is supposed to handle 'justify-self', but no browser supports it on block boxes. | |||
| /// Instead, <center> and <div align> are implemented via internal 'text-align' values. | |||
| /// Instead, <center/> and <div align/> are implemented via internal 'text-align' values. | |||
There was a problem hiding this comment.
Suggested change
| /// Instead, <center/> and <div align/> are implemented via internal 'text-align' values. | |
| /// Instead, `<center>` and `<div align>` are implemented via internal 'text-align' values. |
| @@ -450,7 +450,7 @@ impl TextRun { | |||
| /// Whether or not this character will rpevent a soft wrap opportunity when it | |||
| /// comes before or after an atomic inline element. | |||
| /// | |||
| /// From https://www.w3.org/TR/css-text-3/#line-break-details: | |||
| /// From <https://www.w3.org/TR/css-text-3/#line-break-details:> | |||
There was a problem hiding this comment.
Suggested change
| /// From <https://www.w3.org/TR/css-text-3/#line-break-details:> | |
| /// From <https://www.w3.org/TR/css-text-3/#line-break-details>: |
Signed-off-by: Sandeep Pillai <sandeeppillai@Sandeeps-MacBook-Air.local>
atbrakhi
changed the title
components/layout_2020
mrobinson
approved these changes
Mar 8, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach docdoes not report above stated warnings./mach build -ddoes not report any errors./mach test-tidydoes not report any errors