Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rustdoc warnings in component/layout_2020 #31588

Conversation

maureenblack
Copy link
Contributor

@maureenblack maureenblack commented Mar 8, 2024

Resolved remaining warning in components/layout_2020/flow/textrun.rs part of #31575 by

  • Converting urls to hyperlinks
  • Fixing unresolved links by appropriately linking to parent

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

@maureenblack maureenblack marked this pull request as ready for review March 8, 2024 16:16
@atbrakhi atbrakhi changed the title Fix rustdoc warnings in component/layout_2020/flow/textrun.rs #31575 Fix rustdoc warnings in component/layout_2020 Mar 8, 2024
@maureenblack maureenblack reopened this Mar 8, 2024
@maureenblack maureenblack marked this pull request as draft March 8, 2024 16:21
@atbrakhi
Copy link
Member

atbrakhi commented Mar 8, 2024

looks like this was tackled in #31587 , might be a good idea to look into some other files.

@maureenblack maureenblack reopened this Mar 8, 2024
@maureenblack maureenblack marked this pull request as ready for review March 8, 2024 16:25
@maureenblack
Copy link
Contributor Author

thanks @atbrakhi

Signed-off-by: Wepngong Maureen <maureenwepngong@gmail.com>
@maureenblack maureenblack force-pushed the Fix-rustdoc-warnings-in-components_layout_2020_flow_textrun.rs branch from d6ae1a6 to 29bb0be Compare March 8, 2024 19:23
@mrobinson mrobinson enabled auto-merge March 8, 2024 19:41
@mrobinson mrobinson added this pull request to the merge queue Mar 8, 2024
Merged via the queue into servo:main with commit 0f4522c Mar 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants