Fix vertical alignment at the root of an IFC #31636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loirooriol
added
A-layout/inline
A-layout/2020
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#8257712869) for Linux WPT |
4 tasks
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#45074) with upstreamable changes. |
|
|
Loirooriol
force-pushed
the
vertical-align
branch
4 times, most recently
from
b5ff06c
to
96978e5
Compare
Loirooriol
added
T-linux-wpt-2013
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#45074). |
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#8261596814) for Linux WPT |
|
Test results for linux-wpt-layout-2013 from try job (#8261596814): Flaky unexpected result (12)
Stable unexpected results that are known to be intermittent (13)
|
|
Test results for linux-wpt-layout-2020 from try job (#8261596814): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (12)
Stable unexpected results (1)
|
|
|
At the root of an inline formatting context, we used its vertical-align in order to compute the strut. That was wrong, since vertical-align on a block container shouldn't affect the contents, it should only affect the alignment of the block container (if it's inline-level) within the parent IFC. This was only working well if the block container was block-level, since effective_vertical_align_for_inline_layout returned `baseline` for block-level boxes. Instead of the outer display type, this patch changes the logic to check whether we are at the root of the IFC.
Loirooriol
force-pushed
the
vertical-align
branch
from
96978e5
to
c596333
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#45074). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the root of an inline formatting context, we used its vertical-align in order to compute the strut. That was wrong, since vertical-align on a block container shouldn't affect the contents, it should only affect the alignment of the block container (if it's inline-level) within the parent IFC.
This was only working well if the block container was block-level, since effective_vertical_align_for_inline_layout returned
baselinefor block-level boxes.Instead of the outer display type, this patch changes the logic to check whether we are at the root of the IFC.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors