Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertical alignment at the root of an IFC #31636

Merged
merged 1 commit into from Mar 13, 2024

Commits on Mar 13, 2024

  1. Fix vertical alignment at the root of an IFC

    At the root of an inline formatting context, we used its vertical-align
    in order to compute the strut. That was wrong, since vertical-align
    on a block container shouldn't affect the contents, it should only
    affect the alignment of the block container (if it's inline-level)
    within the parent IFC.
    
    This was only working well if the block container was block-level, since
    effective_vertical_align_for_inline_layout returned `baseline` for
    block-level boxes.
    
    Instead of the outer display type, this patch changes the logic to check
    whether we are at the root of the IFC.
    Loirooriol committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c596333 View commit details
    Browse the repository at this point in the history