Obey white-space when intrinsically sizing an IFC #31660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loirooriol
added
A-layout/text
A-layout/2020
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#8278741244) for Linux WPT |
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#45102) with upstreamable changes. |
mrobinson
reviewed
Mar 14, 2024
|
Test results for linux-wpt-layout-2013 from try job (#8278741244): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (14)
|
|
Test results for linux-wpt-layout-2020 from try job (#8278741244): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (15)
Stable unexpected results (21)
|
|
|
Loirooriol
force-pushed
the
intrinsic-sizing-white-space
branch
from
19a6e0a
to
e28bfe5
Compare
|
🔨 Triggering try run (#8280494677) for Linux WPT |
|
🤖 This change no longer contains upstreamable changes to WPT; closed existing upstream pull request (web-platform-tests/wpt#45102). |
|
Test results for linux-wpt-layout-2020 from try job (#8280494677): Flaky unexpected result (8)
Stable unexpected results that are known to be intermittent (20)
Stable unexpected results (6)
|
|
|
Loirooriol
force-pushed
the
intrinsic-sizing-white-space
branch
2 times, most recently
from
dbc39eb
to
4c69bf6
Compare
|
🔨 Triggering try run (#8283924617) for Linux WPT |
|
|
Loirooriol
force-pushed
the
intrinsic-sizing-white-space
branch
from
4c69bf6
to
161c30d
Compare
|
🔨 Triggering try run (#8284651355) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#8284651355): Flaky unexpected result (12)
Stable unexpected results that are known to be intermittent (14)
Stable unexpected results (3)
|
Loirooriol
force-pushed
the
intrinsic-sizing-white-space
branch
from
161c30d
to
a8339e0
Compare
|
|
The old logic was assuming that all whitespace was a break opportunity, and that no newlines would be preserved. Note that text shaping considers the advance of a newline to be the same as a space. This was problematic because if we have a segment with a preserved space and newline, only the advance of the space should contrinute to the size of the block container. Therefore, I'm changing the breaker logic in other to have newline characters in their own segment. Then glyph_run_is_whitespace_ending_with_preserved_newline can just be renamed to glyph_run_is_preserved_newline. This patch is still not perfect because it doesn't check allow_wrap(), so `nowrap` is treated like `normal`, and `pre-wrap` like `pre`.
Loirooriol
force-pushed
the
intrinsic-sizing-white-space
branch
from
a8339e0
to
c295e25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old logic was assuming that all whitespace was a break opportunity,
and that no newlines would be preserved.
Note that text shaping considers the advance of a newline to be the same
as a space. This was problematic because if we have a segment with a
preserved space and newline, only the advance of the space should
contrinute to the size of the block container. Therefore, I'm changing
the breaker logic in other to have newline characters in their own
segment.
Then glyph_run_is_whitespace_ending_with_preserved_newline can just be
renamed to glyph_run_is_preserved_newline.
This patch is still not perfect because it doesn't check allow_wrap(),
so
nowrapis treated likenormal, andpre-wraplikepre../mach build -ddoes not report any errors./mach test-tidydoes not report any errorswhite-space#31652/css/css-text/tab-size/fail because thetab-sizeis not enabled on Servo./_mozilla/css/white-space-pre-wrap.htmfails because of Whitespace withwhite-space: pre-wrapat the end of the line should hang #31667