Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy: Fixed warnings in htmlimageelement.rs #31800

Merged
merged 2 commits into from Mar 21, 2024
Merged

Clippy: Fixed warnings in htmlimageelement.rs #31800

merged 2 commits into from Mar 21, 2024

Conversation

Aaryakhandelwal
Copy link
Contributor

@Aaryakhandelwal Aaryakhandelwal commented Mar 21, 2024 •
edited by mrobinson

Fixed warnings present in htmlimageelementt.rs and htmlframeelement.rs

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes are part of Fix as many clippy problems as possible #31500
  • These changes do not require tests because they are only fixing the clippy warnings and no functionality changes.

jdm
jdm approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jdm jdm added this pull request to the merge queue Mar 21, 2024
@mrobinson mrobinson removed this pull request from the merge queue due to a manual request Mar 21, 2024
@mrobinson mrobinson added this pull request to the merge queue Mar 21, 2024
Merged via the queue into servo:main with commit 7cdff9d Mar 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Aaryakhandelwal @jdm @mrobinson