New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: Fix `needless_late_init` warning in `components/script` #32052

Merged

jdm merged 1 commit into servo:main from oluwatobiss:clippy/fix-needless-late-init-warning

Apr 11, 2024

Contributor

oluwatobiss commented Apr 11, 2024

Merge late variable initialization with its let statement to fix the needless_late_init warning.

ref: https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Fix as many clippy problems as possible #31500
These changes do not require tests because they only resolve clippy warnings. They do not change functionalities.


          clippy: Fix needless_late_init warning

8e9ca94

jdm approved these changes

View reviewed changes

jdm added this pull request to the merge queue

Merged via the queue into servo:main with commit e3ad76d

9 checks passed

oluwatobiss deleted the clippy/fix-needless-late-init-warning branch

April 18, 2024 20:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment